Giter Club home page Giter Club logo

Comments (1)

pajod avatar pajod commented on July 1, 2024

True, but gunicorn in general lacks a distinction between public API (that downstream users can trust to not go away without notice) and internal (preferably underscore-prefixed) API. This one is rather clearly the former case though, being in the parent class and thus reasonably copied to any custom overrides.

I'd suggest approaching cleaning up such oddities from two separate vectors:

  1. add annotation stubs (.pyi) and inline them (after dropping 3.7 compat) and later, so people have an easier time adapting their code using static type checkers
  2. internally, prefer keyword arguments wherever copying the full method signature is not desirable - while retaining compatibility with custom code still using positionals, emitting DeprecationWarning

from gunicorn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.