Comments (5)
Hi @jonathansampson, can you point me to Coinbase's documentation for { status: 'all' }
? If it is a valid query string, then I will add it to the list of accepted params for getOpenOrders
.
from coinbase-pro-node.
@bennycode Certainly, see https://docs.pro.coinbase.com/#list-orders.
I would suggest a getOrders
method in addition to (for backwards compat, assuming others have also been using the method in this manner) modifying getOpenOrders
. getOrders
would then look for status, product_id, and/or pagination values.
from coinbase-pro-node.
I think extending the existing parameter is a good idea. What's your take on that? https://github.com/bennycode/coinbase-pro-node/pull/432/files
from coinbase-pro-node.
@bennycode Thanks! I added a couple comments for your consideration.
from coinbase-pro-node.
Thank you! 🤝 Fixed with #432
from coinbase-pro-node.
Related Issues (20)
- Can't figure out this 400 Error HOT 3
- Thanks! HOT 4
- Websocket example implementation needs to be updated? HOT 2
- Sorry newb here and at my wits end
- Should ws.subscribe() be marked async and await sendMessage()? HOT 2
- Having trouble accessing listCoinBaseAccounts() HOT 10
- Support conversion (USDC -> USD)
- wrong candlesticks data HOT 3
- Portfolio commission
- Maybe update docs for passing channels? HOT 1
- Add ability to generate wallet addresses HOT 2
- Q: onopen does not trigger for authenticated socket in container HOT 2
- Fix code scanning alert - Polynomial regular expression used on uncontrolled data HOT 1
- granularity for websockets HOT 1
- Unable to recreate order book with l2 data
- Coinbase Advanced Trade API support
- Wallet Endpoint - AvailableBalance interface HOT 2
- Is getPaymentMethods() typing broken? (PaymentMethod Interface) HOT 7
- Is TransferInformation Interface Incorrect? HOT 2
- Coinbase Pro doesn't exist (tutorial) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coinbase-pro-node.