Websocket Reconnection Failes about coinbase-pro-node HOT 8 CLOSED

Great. Good luck with your deadlines. 🍀

from coinbase-pro-node.

Hey, can you show me your code? I will try to reproduce this problem on my machine.

from coinbase-pro-node.

Please have look at the source code. In this latest version I unsubscribe and subscribe again when it closes and opens. I have been testing this and see how it goes.

Thanks for helping me out.

from coinbase-pro-node.

Ok, I already see some issues here:

1. You cannot use this.client.ws.unsubscribe when receiving a WebSocketEvent.ON_CLOSE event because the WebSocket is closed so the unsubscribe message cannot be send through the WebSocket anymore
2. You still do await this.client.ws.connect but connect is not a Promise anymore since v1.6.0
3. You don't have to call client.ws.subscribe([this.channel]) after this.client.ws.connect because you are doing this already in your WebSocketEvent.ON_OPEN handler
4. I am not sure if this.client.ws.subscribe is necessary on every WebSocketEvent.ON_OPEN, I would guess you only need to do it for the very first ON_OPEN, can you confirm?

from coinbase-pro-node.

I had the issue even before adding 1. , 3. and 4. One commit before the latest commit.

from coinbase-pro-node.

I updated the code based on 2. and cleaned up 1., 3. and 4.. Let me run again and see how it goes. I also want to do some debugging so I can give you reason(s) why it happens.

Edited:
While I was writing this comment it happened again and I had to restart the program. I tend to thing that this is mostly Coinbase Pro server issue, but I don't know yet.

from coinbase-pro-node.

Hey @baloian, thanks for your intensive testing. You can test against the official coinbase-pro library. It is deprecated but should still be able to connect to the WebSocket. If the problem also shows up with their library, then it tends to be a server issue.

from coinbase-pro-node.

That is a good idea. I will come back to testing in 2 weeks probably as I have some deadlines on my work.

from coinbase-pro-node.