Giter Club home page Giter Club logo

Comments (5)

benmoran56 avatar benmoran56 commented on August 12, 2024

Thanks for opening the ticket. Unfortunately it doesn't seem like it's currently possible for module-only libraries:

This PEP does not support distributing typing information as part of module-only distributions. The code should be refactored into a package-based distribution and indicate that the package supports typing as described above.

That's unfortunate, but I would prefer not to make esper into a package. Being a single-file library is something I really like about it. One of my goals was to allow users to just copy it into their project without necessarily needing to install it.
Any ideas?

from esper.

HexDecimal avatar HexDecimal commented on August 12, 2024

A single package without dependencies isn't much more complex than a single module. You would copy an esper directory instead of a esper.py file and you'd import it the exact same way.

from esper.

benmoran56 avatar benmoran56 commented on August 12, 2024

esper actually was a package in the past, but was consolidated back to a single module due to some user demand.

If you wouldn't mind, could you explain what you mean by it "isn't considered typed" when installing from PyPi?
Running mypy against the module seems to work fine without it. I had a look through the PEP, but couldn't really grasp it all.
I guess my question is: what is this breaking by not existing?

Thanks in advance!

from esper.

HexDecimal avatar HexDecimal commented on August 12, 2024

When it's vendored then its fine, but when it's installed to site-packages then Mypy won't follow the import of it to look at its types, and you have to tell Mypy to ignore the import to continue.

Mypy will assume that local files are typed, but it needs stub-files or py.typed for an external package.

from esper.

benmoran56 avatar benmoran56 commented on August 12, 2024

Thanks for the explaination. And also, thanks for the pull request.
I can't say I'm happy about having to change it just for mypy, but I guess it can't be helped at the moment.

from esper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.