Giter Club home page Giter Club logo

Comments (4)

benfred avatar benfred commented on July 17, 2024 1

Fix is in the 0.7.2 release : https://github.com/benfred/implicit/releases/tag/v0.7.2

from implicit.

nwittenberg avatar nwittenberg commented on July 17, 2024

Upvote. Facing same issue - now we have to manage numpy dependency explicitly. Would be great if this could be addressed.

from implicit.

benfred avatar benfred commented on July 17, 2024

I think we should probably remove this block of code. We're trying to detect a potential performance problem (having BLAS configured to use a threadpool causes severe perf isues since we are also internally multi-threading which leads to thrashing- so we want to make sure that BLAS is configured to just use one thread, and we're using this method to try to figure out which BLAS library is being used by numpy).

Instead I think we should use https://github.com/joblib/threadpoolctl here - which both lets us get the threadpool status for the BLAS libraries, as well as programmatically set it. This means rather than just detecting the perf issue, we can configure BLAS appropriately to not have the issue in the first place.

from implicit.

benfred avatar benfred commented on July 17, 2024

#692

from implicit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.