Precedence in determiners about laravel-localize-middleware HOT 7 CLOSED

Thanks for the suggestion, it's something I've thought about actually and I'll try and get it built soon. I'll leave this issue open until then, and would welcome a PR if yourself or anyone else fancies a go.

from laravel-localize-middleware.

+1

from laravel-localize-middleware.

Hi @dionysiosarvanitis and @shadoWalker89 - I've added this functionality, so check out the updated README:

https://github.com/BenConstable/laravel-localize-middleware#using-multiple-determiners

Let me know what you think! I'll try to release a new version of the package tomorrow, but for now dev-master has the changes.

from laravel-localize-middleware.

FYI, the relevant commit is 7925a09 if you want to have a look at the code.

from laravel-localize-middleware.

This functionality is now in place as of v1.2.0.

from laravel-localize-middleware.

That's great news! Thanks a lot @BenConstable.

I also noticed that header's determineLocale should probably change a little. Since Accept-Language may include some language-range information we can end up with something like da, en-gb;q=0.8, en;q=0.7 for Accept-Language header.

What do you think about this:

public function determineLocale(Request $request)
{
    $header = $request->header($this->header, $this->fallback);

    $accepts = explode(',', $header);

    // Turn en-gb into en
    return  ! isset($accepts[0]) ?: substr($accepts[0], 0, 2);
}

from laravel-localize-middleware.

No worries. Thanks for bringing that to my attention - I've created issue #3 to track this. The code looks like a good start, I'll look at getting an implementation sorted soon.

from laravel-localize-middleware.