Proper meta tags for all pages about centrarium HOT 6 CLOSED

I added these. Happy to put them in a PR?

  <meta property="og:description" content="{% if page.excerpt %}{{ page.excerpt | strip_html | strip_newlines | truncate: 160 }}{% else %}{{ site.description }}{% endif %}" />
  <meta property="og:url" content="{{ site.url }}" />
  <meta property="og:site_name" content="{{ site.title }}" />
  <meta property="og:title" content="{{ site.title }}" />
  <meta property="og:type" content="website" />
  <meta property="og:image" content="{{ "assets/twitter_360.png"| prepend: site.baseurl | prepend: site.url }}" />
  <meta property="og:image:type" content="image/png" />
  <meta property="og:image:width" content="360" />
  <meta property="og:image:height" content="360" />

  <!-- Twitter: card tags -->
  <meta name="twitter:card" content="summary">
  <meta name="twitter:title" content="{{ site.title }}">
  <meta name="twitter:description" content="{% if page.excerpt %}{{ page.excerpt | strip_html | strip_newlines | truncate: 160 }}{% else %}{{ site.description }}{% endif %}">
  <meta name="twitter:image" content="{{ "assets/twitter_360.png" | prepend: site.baseurl | prepend: site.url }}">
  <meta name="twitter:url" content="{{ site.url }}">  

  <!-- Open Source Protocol -->
  <link rel="profile" href="http://osprotocol.com" />
  <meta property="os:repo" content="https://github.com/RichardLitt/wordhoardpress.com" />
  <meta property="os:rcs_type" content="git" />
  <meta property="os:src" content="[email protected]:RichardLitt/wordhoardpress.com.git" />

from centrarium.

The first two are Facebook and Twitter, right? For og:image and twitter:image, is "assets/twitter_360.png" something specific to your site? It should be configurable in either _config.yml or on a page-by-page basis in the front matter.

If you want to include the Open Source Protocol stuff, I'd add fields in _config.yml for users to configure and (optionally) include them.

from centrarium.

If you're willing to make it more customizable (at least site-wide in _config.yml), a PR would be greatly appreciated!

from centrarium.

I'll make another PR for OSP after this, I think these should be included anyway, still a bit biased about OSP because, you know, it's mine. You sure you cool with that?

from centrarium.

I hadn't heard of OSP until just now, and I didn't realize you had worked on it!

I'm totally cool with adding OSP, I just want it to be configurable. If the consumer of the theme wants to use OSP to link to their source, they can add the fields in _config.yml in the protocols section you added in #5 to generate the meta tags. If the fields aren't found, the corresponding meta tags shouldn't be included.

You should also definitely update the README to mention OSP so people will use it. Feel free to link back to your site or any pages describing what OSP is.

from centrarium.

PR'ed. Cool, thanks. I added a link in the config to explain what it is, might be good to add a section to the README.

from centrarium.