Comments (2)
The crash in the provided example filter (https://raw.githubusercontent.com/martialboniou/poe_filter_demo/master/Demo_Item_Filter.filter) is caused by line 431:
SetBorderColor 191 109 16 #Pantone Metallic 8963 C
This is due to the current parsing of Color BlockItems not respecting comments, and greedily consuming the 8963 which it then tries to put into the B part of the ARGB Color that the BlockItem Color is stored in. Due to this being a byte, the value overflows as it's greater than 255 and throws the error. This will be fixed in the next release alongside the Theme support (which will use these Color comments to determine shared block colour groups).
As an aside, any changes to text within the header of a script are unlikely to be the cause of crashes, as this isn't parsed at all, it's just dumped into the Description field of the Script class.
from filtration.
Fix committed to master, closing issue.
from filtration.
Related Issues (20)
- the 'Advanced' button in color sections and the sound icon (for play sound alert) does not work HOT 14
- Saving an item filter with 1 or more MinimapIcon block items results in an incorrect message box
- Undo Redo? HOT 3
- Theme Tags for Font Size & Minimap Icon Not Shown HOT 3
- Visual block items stop affecting preview after being copied
- Adding block group doesn't add EnableBlockGroups to script
- need support for poe v3.6 HOT 1
- Path of Exile 3.7 Update HOT 1
- Filtration 1.2.1 flagged as malware HOT 1
- Path of Exile 3.8 Update HOT 1
- Upgrading to a release when default POE user data directory does not exist results in prompt HOT 2
- Style copy/paste HOT 1
- [Bug] No previous sound
- Apply Theme "all theme components" Error
- Saving Filters without losing unused filter themes
- Please keep the PlayAlertSound
- 3.9
- Editable block output preview.
- HasInfluence
- season timeline updates vs filtration up to date HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from filtration.