Updates to git commits about meme-creator HOT 10 CLOSED

Resolved all issues I will update the snacks for each commit and then close this issue! (and overwrite master :)

from meme-creator.

I'll try to do some more at lunch today.

from meme-creator.

We can get rid of the style in the view wrapping the image, but we need the view to use it as a ref to take the screenshot! Also we need to keep collapsable or else the app crashes when you try to save it to the gallery.

from meme-creator.

My branch to fix all of these things is called: "fixup-master-3"

from meme-creator.

thanks for doing the investigation. Let's just include it in the starter app then and consider adding a comment so noone else wonders why we did this.

from meme-creator.

@ben-edgar lmk when its ready to review

from meme-creator.

@FuadBalashov @n-kumari please review the branch fixup-master-3!!!! I found some extra time this morning.

https://github.com/ben-edgar/meme-creator/tree/fixup-master-3

@lcc8we @megantracy93 FYI/for review. These are some updates we wanted to make!

from meme-creator.

Looks good, just one comment about setting the ref

from meme-creator.

Thanks @ben-edgar

from meme-creator.

All links to snacks and commits on our presentation has been updated! Closing.

from meme-creator.