Giter Club home page Giter Club logo

Comments (3)

belozierov avatar belozierov commented on May 20, 2024 1

@roisg Hi. It's not a bug, actually it's a stack buffer overflow.

This code will also crash:

func testRecursive() {
	let exp = expectation(description: "testRecursive")
	exp.expectedFulfillmentCount = 1
	DispatchQueue.global().async {
		try? self.recursiveFunction(count: 0)
		exp.fulfill()
	}
	wait(for: [exp], timeout: 3)
}

private func recursiveFunction(count: Int) throws {
	let _ = DispatchQueue.global().sync {
		"random_response"
	}
	print(count)
	if count < 10000 {
		try recursiveFunction(count: count + 1)
	}
}

The problem is that every thread has a stack with a limited size. For example, for background thread on iOS it is 256 kb. And when you call a function recursively, the thread stack fills up with stack frames. And if it reaches its limit, it will crash.
A coroutine also has a stack (I set it to 192 kb). That's why in recursive calls it will also crash, just like a thread when it reaches the limit.

I can only recommend not to use too many recursive calls. Neither inside coroutine nor outside coroutine.

from swiftcoroutine.

roisg avatar roisg commented on May 20, 2024 1

Thank you very much, @belozierov! You're absolutely right. This heavily recursive code was inherited by the usage of server-side Vapor's Futures, but now that it's possible, it's clear that re-working it to be iterative is the way to go.

from swiftcoroutine.

ckornher avatar ckornher commented on May 20, 2024

Would it be possible/desirable to specify a stack size for specific coroutines?

from swiftcoroutine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.