panic: xml: encoding "ISO-8859-1" declared but Decoder.CharsetReader is nil same as #48 about etree HOT 4 CLOSED

Hi again @beevik
I found that

doc.ReadSettings.CharsetReader = func(label string, input io.Reader) (io.Reader, error) {
  return input, nil
}

Resolve the problem.
I will let the issue open in case you have another idea.

Thanks,
TeoV

from etree.

I'll try to take a look at this when I get a chance. Thanks for the report, @TeoV.

from etree.

Hi,

Reading the go source code, this seems to be the normal behavior of the default decoder (in xml.go):

if enc != "" && enc != "utf-8" && enc != "UTF-8" && !strings.EqualFold(enc, "utf-8") {
    if d.CharsetReader == nil {
        d.err = fmt.Errorf("xml: encoding %q declared but Decoder.CharsetReader is nil", enc)
       return nil, d.err
   }
[...]

Gabriel

from etree.

This is now fixed in dd07e7c

from etree.