Giter Club home page Giter Club logo

Comments (8)

hexadecy avatar hexadecy commented on August 11, 2024

Ok I created a special version with the fix #47 only: version 1.12.1.

from angular-material-datetimepicker.

ajmueller avatar ajmueller commented on August 11, 2024

Awesome, thanks so much @hexadecy! I'll switch to this version and put it in our dev environment immediately. Regarding testing:

  • We did run tests simulating slow connections and CPUs in Chrome for 1.17.1. We'll be sure to the same for 1.12.1. Unfortunately, in both cases (and even when they were combined), we were unable to reproduce the issue on our dev machines.
  • I'll make sure to test IE11 as well. We don't have any users on IE10 or lower.
  • I haven't heard of the issue happening on mobile, though our user base that accesses the page where this is happening is almost entirely desktop-browser based.

Thanks again for the quick help and I'll be sure to keep you updated on how this works for us.

from angular-material-datetimepicker.

hexadecy avatar hexadecy commented on August 11, 2024

My guess is with 1.13.3, if it's a moment date it will not be converted back to a js date as before. Did you pass a moment or a js string date to the model?

from angular-material-datetimepicker.

ajmueller avatar ajmueller commented on August 11, 2024

@hexadecy sorry for the delay, I took yesterday off work.

We do, in fact, pass a Moment object to the model and not a JS date.

from angular-material-datetimepicker.

hexadecy avatar hexadecy commented on August 11, 2024

I did a lot of work for timezone in #31. Do you use edit-input=true.

@ajmueller Can you console log a typical moment object from your backend server, I want to have a look at ._tzm and ._isUTC.

from angular-material-datetimepicker.

ajmueller avatar ajmueller commented on August 11, 2024

@hexadecy I ended up figuring out the issue and I feel awful because it's entirely on our end and not in the picker at all. While putting together a Plunkr example that more holistically represents our usage, it suddenly hit me what was happening and the timing with our upgrade to 1.17.1 just happened to coincide with an increase in managing events during both daylight time and standard time.

Long story short, it's always important to make sure your scoped variable values are what you expect in a service with shared data.

And now I owe you a 🍺 or ☕️ . Or a week's worth 😄

from angular-material-datetimepicker.

hexadecy avatar hexadecy commented on August 11, 2024

@ajmueller I'm glad it's on your side 😄. Happy 🎃!

from angular-material-datetimepicker.

ajmueller avatar ajmueller commented on August 11, 2024

I'm glad it's on our side as well. Happy 🎃 to you, too!

from angular-material-datetimepicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.