Comments (8)
Ok I created a special version with the fix #47 only: version 1.12.1.
- Please test with a slow connection : https://helpdeskgeek.com/networking/simulate-slow-internet-connection-testing
- Test with a slow cpu: https://stackoverflow.com/questions/8521683/is-there-a-way-to-throttle-javascript-performance-to-simulate-a-slow-client.
- Test with Internet Explorer 10-11.
- Do you have the issue on mobile too?
from angular-material-datetimepicker.
Awesome, thanks so much @hexadecy! I'll switch to this version and put it in our dev environment immediately. Regarding testing:
- We did run tests simulating slow connections and CPUs in Chrome for 1.17.1. We'll be sure to the same for 1.12.1. Unfortunately, in both cases (and even when they were combined), we were unable to reproduce the issue on our dev machines.
- I'll make sure to test IE11 as well. We don't have any users on IE10 or lower.
- I haven't heard of the issue happening on mobile, though our user base that accesses the page where this is happening is almost entirely desktop-browser based.
Thanks again for the quick help and I'll be sure to keep you updated on how this works for us.
from angular-material-datetimepicker.
My guess is with 1.13.3, if it's a moment date it will not be converted back to a js date as before. Did you pass a moment or a js string date to the model?
from angular-material-datetimepicker.
@hexadecy sorry for the delay, I took yesterday off work.
We do, in fact, pass a Moment object to the model and not a JS date.
from angular-material-datetimepicker.
I did a lot of work for timezone in #31. Do you use edit-input=true
.
@ajmueller Can you console log a typical moment object from your backend server, I want to have a look at ._tzm and ._isUTC.
from angular-material-datetimepicker.
@hexadecy I ended up figuring out the issue and I feel awful because it's entirely on our end and not in the picker at all. While putting together a Plunkr example that more holistically represents our usage, it suddenly hit me what was happening and the timing with our upgrade to 1.17.1 just happened to coincide with an increase in managing events during both daylight time and standard time.
Long story short, it's always important to make sure your scoped variable values are what you expect in a service with shared data.
And now I owe you a 🍺 or ☕️ . Or a week's worth 😄
from angular-material-datetimepicker.
@ajmueller I'm glad it's on your side 😄. Happy 🎃!
from angular-material-datetimepicker.
I'm glad it's on our side as well. Happy 🎃 to you, too!
from angular-material-datetimepicker.
Related Issues (20)
- min time and max time HOT 1
- Add mdDialog hasBackdrop option HOT 4
- Add am/pm text customization HOT 2
- Do you have this in a non-angular version? HOT 1
- Could not find a declaration HOT 1
- Setting shortTime=true on a date picker shows AM/PM indicator HOT 4
- Picker icons cause layout issues, show-icon enables too many options HOT 8
- Month displayed is not the same as month view HOT 5
- Upgrade angular library HOT 1
- Cannot set default values for all params of the directive. HOT 1
- Support clearing date from dialog HOT 2
- unable to load datetime picker on dialog box. HOT 5
- ng-change not being triggered as expected and validation failing HOT 5
- If ng-disabled is true. Input field is disabled but buttons are not HOT 4
- Date part is lost when editing time HOT 4
- Which Angular Version? HOT 1
- Option to edit both date and time at the same time on dialog? HOT 1
- Not compatible with Angular 1.8
- User cannot use blue bubble on the clock to set time on Firefox HOT 1
- Min/max date comparison is apparently not timezone-safe HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-material-datetimepicker.