SSR App: Seeing React Warning "Extra attributes from the server: data-from-server" about react-simple-img HOT 6 CLOSED

@bluebill1049 it is good to go! thanks @revskill10 ⚔️

from react-simple-img.

thanks @rhernand3z for reporting the issue ❤️ and @revskill10 for the fix 🙏.

i am re-open this issue, until you have tested and working.

[email protected]

from react-simple-img.

@bluebill1049 This is, to me a temporary fix.
True fix will be like this:
The component will have isServer attribute default to false.
So on running, the isServer is get from a global context. On server, it will be true, on client when hydrating, it'll set to be false.
Or, on building, we could set that isServer at build time.
Because webpack could build two targets: node and web. With each target, user just inject a variable to isServer and each bundle will be set to correct mode.
How do you think ?

from react-simple-img.

hey @revskill10,

thanks for you suggestion and contribution. i think as long as your fix will resolve the server/client mis-match, then we are good. keep it simple and beautiful 👍

cheers
bill

from react-simple-img.

Thanks for the quick turnaround, will be on the lookout once the PR is merged.

from react-simple-img.

@rhernand3z is the issue got resolved?

from react-simple-img.