Comments (10)
I will take a look the provider
issue soon over the weekend. To be honest i probably need to update the context API too.
from react-simple-img.
from react-simple-img.
I tried with initSimpleImg()
running top-level in Page.js
and separately in User.js
. It works perfectly using Gatsby v2 in dev, but when I build it, the images only update if I start on Page
, not if I first load another page.
from react-simple-img.
Hi @millette i have updated with a patch to fix the provider bug :)
from react-simple-img.
I just upgraded my project with the patch version and it broke on my end. For example: https://github.com/millette/gatsby-starter-location-github/blob/master/src/components/github-user.js#L8
I moved the init call to the page component (pages/index.js) and contrary to previous version, I was not getting observer errors when I split SimpleImg and initSimpleImg to 2 files, but now, in either case, the images aren't getting loaded, only the gradient placeholder is shown.
from react-simple-img.
Don't worry too much about my comments, as I said, I'm just getting started with Gatsby and my React Fu isn't the greatest either. Also, I found out gatsby has it's own image lazy loader, but I'm not 100% sure it would be effective in my case.
I found using your component to be very simple and effective. For instance, this turned out rather well: https://rollo-venezuela-wtmknramwg.now.sh/ :-)
from react-simple-img.
hey @millette,
lovely demo! i am glad it worked for you! i checked your code for working on per component you probably should use provider
. but if it worked for you with previous patch, that's all it matters. 😄
thanks
bill
from react-simple-img.
ok i have made a new patch this should be fixed now (1.3.16), going to close the issue in the next couple days, if nothing reports :) thanks
from react-simple-img.
Looking good on my end. As I mentionned, last patch broke it for me, but with this one, my project works again. Thanks!
P.S.: I will eventually revisit my code to make proper use of provider
.
from react-simple-img.
👍 thanks @millette
from react-simple-img.
Related Issues (20)
- TypeError: placeholder.indexOf is not a function HOT 5
- Number.isNaN not supported in IE11 HOT 3
- Image can't be loaded on FireFox HOT 7
- Support for SEO (no script tag) HOT 9
- Inline CSS is stretching images HOT 14
- Image src not updated when component rerenders HOT 4
- Fallback/default img when img url is not valid HOT 7
- Wanting to turn off all class insertions HOT 5
- Add browser support to README HOT 9
- Using webp images with <picture> and multiple source sets? HOT 2
- Typescript types generated ? HOT 2
- disableAnimationAfterCache does not exist in source code HOT 1
- Height and width not accepting % HOT 1
- When Running Docker on LocalHost, Image Always Behind White Background HOT 2
- threshold doesn't take in account scrolling down HOT 5
- Invalid empty srcSet attribute in SSR HOT 6
- Placeholder does not have `alt` attribute HOT 2
- not showing img after re-rendering component HOT 1
- Images loaded over network twice with cache disabled HOT 4
- When Component Re-Renders with new src tag, image does not change. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-simple-img.