Comments (3)
I would be happy with option 1. The protocol spec does not allow clients to assume only LF, it just says that commands produce yaml, so if a client can't handle CF LF pairs, the client is broken. We shouldn't bend over too far to accommodate broken clients.
There's also option 5: keep it the way it is. :) It's not that hard making .expected files, at least not in vim. I understand your point, though. We shouldn't make this unnecessarily hard.
This reminds me of another idea to consider. Reformat responses to use the subset of yaml that is also valid json, and update the protocol doc to say that responses are both json and yaml. The motivation for this goes beyond newline characters, so maybe it's best to leave this for another day.
from beanstalkd.
Ah - it hadn't occurred to me that vim made mixed-newlines so easy, my editor had normalized them to LF, and on top of that I was misinterpreting the false-fails caused by netcat as being newline problems.
So option 5 - keep it the way it is - sounds good to me.
See also my comment on issue #26 regarding a basic python replacement for netcat.
from beanstalkd.
Okay, closing this issue.
from beanstalkd.
Related Issues (20)
- Error on building beanstalkd 1.12 source from spec file HOT 3
- Connection lost moves "reserved" jobs to "ready" HOT 3
- wish add batch put and batch reserve features HOT 3
- Ubuntu - 1.11-1: OUT_OF_MEMORY (Too many open files) despite very high ulimit HOT 2
- Suggested way to set Beanstalk UNIX domain socket permissions HOT 2
- Use GITHUB_TOKEN for authenticating to the docker registry HOT 1
- Make the new images public HOT 1
- Client test suites fail HOT 1
- Which is the best way to replicate between beanstalkd? HOT 4
- Invalid yaml response in stats
- New release ? HOT 2
- memory leak, how to help finding it HOT 8
- Allow delete job from another connection HOT 2
- Put command returns multiple errors HOT 2
- Reserve and Reserve-with-timeout commands return RESERVED instead of DEADLINE_SOON if there are ready jobs HOT 1
- Put hangs while reserve in progress HOT 1
- Tag docker container for release versions
- How to free the memory used by beanstalkd?
- 1.11 - Out of memory (ulimit?)
- Is the binlog format documented anywhere?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beanstalkd.