Giter Club home page Giter Club logo

Comments (3)

kr avatar kr commented on July 19, 2024

I would be happy with option 1. The protocol spec does not allow clients to assume only LF, it just says that commands produce yaml, so if a client can't handle CF LF pairs, the client is broken. We shouldn't bend over too far to accommodate broken clients.

There's also option 5: keep it the way it is. :) It's not that hard making .expected files, at least not in vim. I understand your point, though. We shouldn't make this unnecessarily hard.

This reminds me of another idea to consider. Reformat responses to use the subset of yaml that is also valid json, and update the protocol doc to say that responses are both json and yaml. The motivation for this goes beyond newline characters, so maybe it's best to leave this for another day.

from beanstalkd.

pda avatar pda commented on July 19, 2024

Ah - it hadn't occurred to me that vim made mixed-newlines so easy, my editor had normalized them to LF, and on top of that I was misinterpreting the false-fails caused by netcat as being newline problems.

So option 5 - keep it the way it is - sounds good to me.

See also my comment on issue #26 regarding a basic python replacement for netcat.

from beanstalkd.

kr avatar kr commented on July 19, 2024

Okay, closing this issue.

from beanstalkd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.