Giter Club home page Giter Club logo

Comments (4)

bryannaegele avatar bryannaegele commented on June 1, 2024 1

I'm not sure why that isn't the behavior.

from telemetry.

josevalim avatar josevalim commented on June 1, 2024

We don't perform any merging, so indeed the docs are inaccurate. PRs welcome!

from telemetry.

vanvoljg avatar vanvoljg commented on June 1, 2024

Hello! I'm still a tad confused about this, even after the linked PR got merged.

In the quoted documentation paragraph, the docs mention that a reporter should be able to rely entirely on the stop event. However, this doesn't seem possible if StartMetadata isn't merged (automatically) into StopMetadata, because there is possibly a large amount of metadata that is unavailable to the stop event by default, and must be manually merged into the stop metadata when a span wrapper is implemented.

This seems to me that it makes it very easy to implement telemetry in a way which makes reporters very arduous to write (with need for long-running state to track and match span-related events via their references). I'm unsure if this is the intent, or if the documentation is incorrect, or if I'm just misunderstanding things entirely.

from telemetry.

josevalim avatar josevalim commented on June 1, 2024

However, this doesn't seem possible if StartMetadata isn't merged (automatically) into StopMetadata,

we should document that it is extremely Recommended for callers to return the stop metadata as a superset of the start metadata.

from telemetry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.