Giter Club home page Giter Club logo

Comments (2)

codahale avatar codahale commented on September 24, 2024

Adding a salt, constant or otherwise, to a password before hashing it with bcrypt doesn't make any sense.

from bcrypt-ruby.

jomo avatar jomo commented on September 24, 2024

Even without custom salting, this is still a security concern.

For a simplified proof of concept, consider someone using the password
000000000000000000000000000000000000000000000000000000000000000000000000kEGF8vY6rR78kOb65WCbRw.
According to zxcvbn this is a really good password that's practically impossible to crack.
However, an attacker would only need to crack 000000000000000000000000000000000000000000000000000000000000000000000000,
which could be cracked in seconds.

The culprit is that bcrypt (eksblowfish) has an upper limit of 72 characters (56b) for passwords, anything else is cut off.

This has also been discussed in rails/rails#14591, which led to setting a limit of 72 characters when using has_secure_password.

I think it would be best if BCrypt would raise an error if the password is longer than 72 characters. Can this be re-opened?

from bcrypt-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.