Giter Club home page Giter Club logo

Comments (5)

cmhodgson avatar cmhodgson commented on June 16, 2024

This one is particularly weird because the street type was spelled wrong, and then not matched, and then matched as a suffix instead of a prefix... basically, the "st" of street is becoming the "st" of saint, and that is enough of a partial match that the word king is ignored... I think we may need some special handling for "st", but we also need to change something in the scoring or parsing because that combination of faults isn't sensible.

from ols-geocoder.

cmhodgson avatar cmhodgson commented on June 16, 2024

estimate is to fix this specific case, more general "meta-analysis of faults" is the sort of thing we would time-box to how much you want to spend as there is no shortage of faults to analyze.

from ols-geocoder.

mraross avatar mraross commented on June 16, 2024

Please add appropriate estimate label (e.g., estimate 2 hours) for the specific fix.

from ols-geocoder.

cmhodgson avatar cmhodgson commented on June 16, 2024

I set the estimate to 21 for specifically fixing the handling of multiple inconsistent street-type faults. I think I may need to change the order of some logic. Much testing is required.

Maybe that is what you meant by "meta-analysis of faults" ... I took it to mean a much broader analysis of which this is was just one example of something weird. When we do a broader analysis type of thing, we usually time box it, say, lets spend 2 weeks reviewing these errors and try to find the easiest/ most effective fixes/tweaks/etc.

from ols-geocoder.

cmhodgson avatar cmhodgson commented on June 16, 2024

Perhaps all we really need to do is add a special case for not prefix-matching "st" (as in the street type) to "st" as in saint patrick's, because "st" is way too common to be used in that way. This actually seems to be a pretty pervasive problem.

from ols-geocoder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.