Giter Club home page Giter Club logo

Comments (8)

gleeming avatar gleeming commented on June 19, 2024

I will need to test if this affects the data prep scripts that batch geocode and canonicalize street names for the site vetting process. The scoring logic is dependent on interpreting fault patterns, so it may need to be tweaked. It is possible this could also affect other users that parse out fault details.

from ols-geocoder.

mraross avatar mraross commented on June 19, 2024

We could make fault values conditional on a request parameter like includeFaultValues:Boolean with a default of false for backward compatibility.

from ols-geocoder.

cmhodgson avatar cmhodgson commented on June 19, 2024

This is implemented now in my local dev environment, on our next deploy to gazelle we can test the affects on the scripts.

from ols-geocoder.

gleeming avatar gleeming commented on June 19, 2024

The FME site candidate fault parsing logic is unaffected by this change

from ols-geocoder.

cmhodgson avatar cmhodgson commented on June 19, 2024

Presently this change is only output in JSON format - we need to consider if and how we want to output the value in other formats such as CSV and shape. Presently the faults are output in a single field in all other formats, with a structure such as:
LOCALITY.isAlias:1;UNRECOGNIZED.notAllowed:3

I propose a format such as:

Vancouver:LOCALITY.isAlias:1;BACK ALLEY GARBAGE:UNRECOGNIZED.notAllowed:3

It should be noted that any users who are parsing this field from a non-JSON output would potentially be affected by this change. (this includes the FME site candidate logic mentioned above).

from ols-geocoder.

mraross avatar mraross commented on June 19, 2024

Is there a format that wouldn't require a change to current parsing? Maybe:

Vancouver:LOCALITY.isAlias:1;UNRECOGNIZED.notAllowed:3;Value:BACK ALLEY GARBAGE

from ols-geocoder.

cmhodgson avatar cmhodgson commented on June 19, 2024

We will not add the "value" field to the fault output in formats other than HTML and JSON at this time. This will ensure we do not cause any backward compatibility issues with these other formats.

from ols-geocoder.

BK01 avatar BK01 commented on June 19, 2024

Validated in Geocoder 4.1-Gold (DLV) in JSON, HTML, XHTML for "1175 Douglas St, Saanich, BC"

from ols-geocoder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.