Comments (5)
GregTurner
commented on June 12, 2024
1
Fixed in v0.4.1
from mygovbc-bootstrap-theme.
GregTurner
commented on June 12, 2024
@acoard thanks for finding and reporting this, I think the :hover should be #294266 for .btn-default instead of that yellow.
Re: the btn.default = btn.primary not sure why that was decided, but it's worth re-considering when doing the bootstrap v4 of this theme.
from mygovbc-bootstrap-theme.
acoard
commented on June 12, 2024
Happy to help take part in this wonderful thing called open source. ;)
Glad to hear you guys are willing to reconsider .btn-default not being
identical to .btn-primary. I still strongly support having the previous
.btn-default re-instated. It's lack of colour made it perfect for cases
where the button didn't warrant much visual weight (e.g. "Print" or "Back"
buttons). In most cases we use .btn-primary to indicate the primary action
the user will take on that page, and .btn-default for optional or
infrequent actions.
I'll make sure to keep an eye out for when you folks are doing the
bootstrap v4 upgrade and can make the case there, if appropriate.
…On Wed, Sep 6, 2017 at 1:11 PM, Greg Turner ***@***.***> wrote:
@acoard <https://github.com/acoard> thanks for finding and reporting
this, I think the :hover should be #294266 for .btn-default instead of that
yellow.
Re: the btn.default = btn.primary not sure why that was decided, but it's
worth re-considering when doing the bootstrap v4 of this theme.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD_lVnMX3khW3wscvh1-97j_8S0EyYkvks5sfvxygaJpZM4POz4s>
.
from mygovbc-bootstrap-theme.
acoard
commented on June 12, 2024
For anyone else coming to this thread and looking to get the old .btn-default stylings while waiting for the fix, here's the SCSS:
.btn-default {
color: #333;
background-color: #f4f6f9;
border-color: #ccc;
&:hover {
color: #333;
background-color: #d3dbe7;
border-color: #adadad;
}
}
//Bonus, .btn-primary hover colour:
.btn-primary:hover {
background-color: #294266;
}
from mygovbc-bootstrap-theme.
GregTurner
commented on June 12, 2024
FYI, there's no btn-default in Bootstrap V4, therefore it won't be an issue going forward.
from mygovbc-bootstrap-theme.
Related Issues (8)
- Feature request. Sass based theme HOT 2
- It's Been a While Since This Repository has Been Updated HOT 7
- Update Theme #1 - Bootstrap Styles Background Updates
- Add missing topics HOT 10
- Add project lifecycle badge HOT 8
- It's Been a While Since This Repository has Been Updated HOT 7
- It's Been a While Since This Repository has Been Updated HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mygovbc-bootstrap-theme.