Comments (9)
swcurran
commented on July 20, 2024
Arrghh…sorry about that. Shouldn’t have been removed — the shasum is an extra value. Fixing...
from aries-oca-bundles.
swcurran
commented on July 20, 2024
Hmmm…the ID has never been part of that file, because there can be multiple IDs (Schemas, Cred Defs) associated with a given bundle. That is accounted for in the ocabundle.json (one row per identifier), but not in the OCABundleList.json file.
I don’t think it is needed, but could be wrong. Why are you thinking it is needed?
If it is needed, it is easy to add one identifier (the last from the README.md file), or (a little more complicated), I can add the array of identifiers.
Are you sure you need it @amanji ?
from aries-oca-bundles.
amanji
commented on July 20, 2024
I think the shasum is unique so I can use that and it's already included in the payload. The main thing is to be able to link directly to specific bundles. Can close this for now.
from aries-oca-bundles.
swcurran
commented on July 20, 2024
Discussed and a solution defined and implemented here #114 .
from aries-oca-bundles.
swcurran
commented on July 20, 2024
@amanji — the solution we have is not working I don’t think. The dropdown list has many duplicates of the same OCA Bundle. We should have each Bundle only once. Either the code you have should have filter to list each unique path only once, or there should be (as before) only one entry in the array per per path to a bundle.
What makes the most sense to you?
from aries-oca-bundles.
amanji
commented on July 20, 2024
The duplication is because the same names map to multiple paths. I don't think we can get around that unless we have entirely unique names for each path. The question becomes what is easier for a user to understand? Should we just display the path then and show the name in brackets?
from aries-oca-bundles.
amanji
commented on July 20, 2024
Let me first check to see this isn't a bug. I thought the list was already one entry/path per bundle
from aries-oca-bundles.
swcurran
commented on July 20, 2024
No — you had asked for one ID (schemaId/credDefId being the IDs) per entry, and multiple IDs point to the same Bundle. I had thought you were going to filter the list to be one entry per path, but likely misunderstood. That multiple IDs point to the same bundle path is expected.
from aries-oca-bundles.
amanji
commented on July 20, 2024
Sorry I get what's going on now. I will filter the list by path. It will filter out some ID's but that shouldn't matter if its pointing to the same bundle
from aries-oca-bundles.
Related Issues (20)
- Fix JQ handling error in OCA Bundle generator script genBundle.sh when using large lines in the branding.json file -- e.g. inline images HOT 1
- Remove the OCA Explorer application HOT 3
- Disable GH pages for OCA Explorer HOT 1
- Update documents in the Aries OCA Bundle repo to make sense on the published site HOT 1
- Add OCA Bundle to the published site to enable the paths to work from the JSON files to the bundle HOT 1
- Fix links in rendered site
- LSBC Member credential logo throwing 404 error
- The header logo is not displaying correctly in the deployed pages HOT 1
- "attribute_character_encoding" should be renamed to "attr_character_encoding" HOT 2
- GHA to validate OCABundle.json on opened PRs HOT 3
- Don’t continue the OCA Explorer Tour after saying Skip or ending
- Hitting the `esc` key when the tutorial is running should skip the tutorial
- Wording changes to tutorial button
- Discussion: What would be in an AnonCreds "presentation request" OCA Bundle consist? HOT 1
- Need all OCABundle.json files to validate against Schema.json File HOT 4
- how do we know a bundle has been updated? HOT 11
- Add a GHA to generate the two root folder JSON files and push to the gh-pages branch HOT 8
- Extend the GH Pages to include all of the documentation on the site HOT 1
- Update the script to navigate under OCABundles and find all bundles HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aries-oca-bundles.