Improve ASN1 Lib about pc-dart HOT 4 CLOSED

I found it very odd how encodedBytes is exposed. From what I can see it's the memoized result from encode(). It seems like it should be a private implementation detail?

Also throws off people switching from the ASN1Lib package, since their encodedBytes should be changed to encode().

Edit:

The encoding from ASN1Integer(BigInt.from(0)) differs from the current ASN1Lib package and is maybe buggy

Yes I have found the same problem.

Also, seems like the implementation mentions:

Uint8List encodeBigInt(BigInt number) {
  // Not handling negative numbers. Decide how you want to do that.

Not too sure how important that is, but I suppose it should be decided before 2.0.0 stable?

from pc-dart.

@mwcw @gnawf
I created a PR to fix the above mentioned things.

from pc-dart.

Related to Ephenodrom/Dart-Basic-Utils#31...

⚠️ I will admit that I am not very familiar with ASN1. The following comments are based on feedback from an exercise I went through in attempting to migrate asn1lib code to pointycastle.

Consider the following:

Is tag really something that would/could/should be changed? Why not hard-code it like:

   ASN1BitString( 
       {this.stringValues, this.elements}) 
       : super(tag: ASN1Tags.BIT_STRING); 

?

Migrating from asn1lib1 requires specifying the named parameter, which seems excessive for most use-cases. And does it really make sense to potentially have stringValues and elements? Maybe multiple constructors or factory methods to handle different use-cases makes more sense? Like:

    ASN1BitString(this.stringValues) : super(tag: ASN1Tags.BIT_STRING);
  
    ASN1BitString.fromElements(this.elements) : super(tag: ASN1Tags.BIT_STRING); 

?

from pc-dart.

Improvements are already merged. Complaints cannot be traced, because the effort for a change is limited.

from pc-dart.