Invalid read when querying for a field that doesn't exist about arduinojson HOT 8 CLOSED

Valgrind says it's in JsonObjectBase.cpp:18 which is:

while (token->start < end)

It could be either: token, token->end or token->start that is not initialized.

Unfortunately, it's not easy for me to run Valgrind, because I'm using Visual Studio for the tests.
Maybe it's time for me to move to GCC and gtest...

from arduinojson.

I had a closer look and it appears that the "tokens" member variable in JsonParser.h is not initialised at all.

I think maybe it should be zeroed in the constructor or else it will be undefined when you try to read past the end of the last token.

from arduinojson.

Writing zeros in the array, just for the sake of it would be a complete waste.
But if there is really a bug, we should be able to write a unit test and fix it.

tokens should be initialized by jsmn_parse(), but maybe some of them are not.
Can you try with the latest version of jsmn?

Do you know which EXPECT_ line triggers this error?
I guess it could be the last one, because the key doesn't exists.

from arduinojson.

Yup it is the last EXPECT in that test.

I'll try out the latest version of Jsmn tomorrow (if we are not already using it).

from arduinojson.

Good!
I'm going to write a unit test.
There must be a sleeping bug here.

from arduinojson.

I can confirm that it is token->start that is uninitialised, it was a large negative number when I stepped through the code.

from arduinojson.

I refactored getNestedTokenCount().

I pushed a fix into the master branch, please give it a try.

from arduinojson.

I can confirm that this bug has been fixed. Thanks :)

from arduinojson.