Giter Club home page Giter Club logo

Comments (6)

hsyed avatar hsyed commented on July 20, 2024

kapt3 doesn't respect the processors attribute (likely I am encoding it incorrectly), it will happily discover processors from the classpath though.

Issue in Kotlin Youtrack

from rules_kotlin.

hsyed avatar hsyed commented on July 20, 2024

implemented in #16 intellij support works well enough with dagger. The references are resolved against the compiled classes, an improvement would be to generate an annotations processing src jar and pass that through, happy for a PR on this.

from rules_kotlin.

cgruber avatar cgruber commented on July 20, 2024

Note, we really don't want to rely on classpath discovery. That's not a required feature of javax.annotation.processing implementations, though it happens to work in javac and kapt3 for now. But we shouldn't rely on non-spec behavior. It's fine for now, but once jetbrains attends to your issue with kapt3 configuration, we should revert to explicitly passing the processors via java_plugin targets.

As to "compilers being invoked twice" - is that necessary? I know javac does multiple "rounds" - I assume kapt3 does this also, with kotlinc, but I don't know that for sure.

from rules_kotlin.

hsyed avatar hsyed commented on July 20, 2024

On classpath discovery: Kapt does not respect the processor list so what I have done for the time being is exclude the plugin entry entirely if it has a null or empty processor_class attribute. Need to wait on JB (link to issue above) to fix this.

Kotlinc does need to be invoked twice once with the kapt plugin config and once without, but this is done within the kotlin builder within the same function so the overhead I suspect is very low.

from rules_kotlin.

hsyed avatar hsyed commented on July 20, 2024

Kotlin Youtrack issue for annotation processor classes configuration.

from rules_kotlin.

hsyed avatar hsyed commented on July 20, 2024

Fixed since 1.2.40

from rules_kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.