Support stamp variables about rules_jsonnet HOT 11 CLOSED

Ah, another option is to create a generated jsonnet_library which contains all the stamping variables. When build in bazel use this generated library, and for dev tools, use the actual file in the search path.

from rules_jsonnet.

@ashi009 I can introduce new stamping variables through --workspace_status_command, so for this to be exhaustive we must dynamically generate the .jsonnet for your library based on these files, which would be kinda bad ass. :)

from rules_jsonnet.

My use case is getting the git branch and hash into labels for rules_k8s.

from rules_jsonnet.

The best I can think of is to use --ext-code buildstamp={...} to pass in such info, and create a libsonnet package to consume it with {default: 'stamping', info: 'is herer'} + std.extVar('buildstamp').

The problem with this approach is that, whenever --ext-code flag is not presented, the build will fail. Which will probably break all dev tool integrations.

from rules_jsonnet.

rereading your answer, it already says "generate", so sorry for not RTFM. That's be great, I think.

from rules_jsonnet.

@mattmoor I've tried to create such libsonnet package with stamp variables inside, then it turned out that rules_jsonnet doesn't know how to handle generated files. Additional -J flags need to be passed to jsonnet.

The proposed patch is https://github.com/xreception/rules_jsonnet/commit/d9acfbec8346266d3b0bcd021004a56af6e105c8

from rules_jsonnet.

Awesome! Would you be able to turn that into a PR?

from rules_jsonnet.

One thing I don't like my CL is that, -J . is not generated from search_paths, but instead manually pinned to appear before all other -J flags. The reason for doing this is because the generated file shared the same name as the placeholder file. So unless -J . appears before the rest, the placeholder file will be used. Which doesn't seem right to me as the placeholder file is not on the transitive dependency graph. 🤦‍♂️

from rules_jsonnet.

I just merged something (hadn't seen this) that might help with this: https://github.com/bazelbuild/rules_jsonnet/pull/37/files

from rules_jsonnet.

What about expanding make variables defined with --define?
The use case I need to handle is injecting an environment specific domain name when generating ingress.json. It would be nice to run bazel --define fqdn=...

from rules_jsonnet.

I created a separate issue #39 (and matching PR) since stamp variables would be useful anyway.

from rules_jsonnet.