ext_code and ext_str are inconsistent with ext_code_files and ext_str_files about rules_jsonnet HOT 4 OPEN

I would be happy to contribute a PR if the maintainers are ok with using a map for all of the args such as ext_code_files and ext_str_files

from rules_jsonnet.

@mariusgrigoriu The main reason I could not implement what you proposed was due to a limitation in bazel/starlark: bazelbuild/bazel#1232. But if you do find a better way of implementing this I would be very happy to get a PR in.

from rules_jsonnet.

I actually did think of some improvement of this a while ago, because it also becomes a bit weird when one uses a filegroup. I was thinking one way of improving this is that if one only provides the ext_str_files or ext_code_files without the corresponding ext_str_file_vars/ext_code_file_vars it could choose the name automatically based on the file name. Which in would probably be fine for >90% of the cases.

from rules_jsonnet.

But either way, happy to get in any improvements you come up with.

from rules_jsonnet.