Support --incompatible_enable_proto_toolchain_resolution about rules_go HOT 9 CLOSED

I am a huge fan of this and will try to work on it in early April unless someone gets to it earlier.

Cc @linzhp

from rules_go.

@fmeum note the rules_python change just landed, and @thesayyn tells me rules_java is already switched. Would be nice to include rules_go in this when rules_proto 6.0.0 final goes out (it's currently RC2)

from rules_go.

@thesayyn I tried using rules_java with --incompatible_enable_proto_toolchain_resolution, but it fails to find a proto_lang_toolchain for Java even with Bazel@HEAD. Do you know what's needed to get this to work?

from rules_go.

Toolchain for java comes from protobuf repo, that's only one we i know of unless @alexeagle added one in his prebuilt toolchains ruleset.

from rules_go.

Right, the flag decouples from the hardcoded toolchain but doesn't automatically supply a replacement. It should be easy to fetch the runtime from Maven exactly like the protobuf docs instruct all non-Bazel users/tools should do. I'll add to the toolchains_protoc

from rules_go.

correction, https://github.com/bazelbuild/examples/blob/never_compile_protoc_again/proto/java/Main.java already shows how this works for Java.

from rules_go.

Is there an example of using this with rules_go?

from rules_go.

Is there an example of using this with rules_go?

You don't need to do anything extra for rules_go, just flip the flag and have a protoc toolchain registered (e.g. from toolchains_protoc). rules_go doesn't use proto_lang_toolchain, so you also don't have to register one.

from rules_go.

Adding the example here: aspect-build/toolchains_protoc#10
(but it's trivial like @fmeum says, no additional toolchain to register)

from rules_go.