Giter Club home page Giter Club logo

Comments (4)

fmeum avatar fmeum commented on June 18, 2024

Could you share a reproducer that we could turn into an integration test?

Cc @JamyDev

from rules_go.

joseluis8906 avatar joseluis8906 commented on June 18, 2024

Basically this is the issue:
If I use the same package name that the package Im testing everything works perfectly.

image

But If I wanna separate the package name of the test files the GOPACKAGESDRIVER starts to emit a false positive about the imported packages like it was imported outside of the parent internal package.

image

from rules_go.

joseluis8906 avatar joseluis8906 commented on June 18, 2024

It is like the GOPACKAGESDRIVER is forcing to implement only white-box tests (having access to everything in the internal package not only exported definitions) it is ok, but most of the time we wanna implement black-box tests (only the exported API of the package not all the internal things).

Thanks in advance for supporting.

from rules_go.

JamyDev avatar JamyDev commented on June 18, 2024

Hmm odd, based on the definition of where it's allowable to use internal packages this should not mark this as an issue. We did recently fix it not allowing you to even have the black box tests like this, so this is more akin to a warning, but I'll have a look to see how we can fix this.

from rules_go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.