Comments (3)
fmeum
commented on June 19, 2024
@DolceTriade Do you have a reproducer? Our tests for nogo don't catch this.
@sluongng @emmaxy Any ideas?
from rules_go.
DolceTriade
commented on June 19, 2024
I can't reproduce it in a minimal set up. I'll try some more and see if its something I can reproduce outside of our repository...
from rules_go.
DolceTriade
commented on June 19, 2024
nvm, I repro'd it.
https://github.com/DolceTriade/monorepo/tree/minimal
INFO: Invocation ID: 8954761e-7090-4656-ae1e-a13279895b82
INFO: Analyzed 2 targets (0 packages loaded, 0 targets configured).
ERROR: /home/hmodi/monorepo/repro/subdir/mod/BUILD.bazel:10:8: GoCompilePkg repro/subdir/mod/mod_test_test.external.a failed: (Exit 1): builder failed: error executing GoCompilePkg command (from target //repro/subdir/mod:mod_test) bazel-out/k8-opt-exec-ST-13d3ddad9198/bin/external/go_sdk/builder_reset/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src repro/subdir/mod/mod.go -src repro/subdir/mod/mod_test.go ... (remaining 26 arguments skipped)
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
compilepkg: nogo: errors found by nogo during build-time code analysis:
bazel-out/k8-fastbuild/bin/repro/subdir/mod/2404402859.go:1:1: at least one file in a package should have a package comment (ST1000)
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.143s, Critical Path: 0.04s
INFO: 2 processes: 2 internal.
ERROR: Build did NOT complete successfully
The file in that module:
// Package mod does a bunch of stuff.
package mod
func Important() {
}from rules_go.
Related Issues (20)
- Unable to get io_bazel_rules_go to work with a custom c++ toolchain HOT 1
- Rules_go 0.47.0 downgraded the gomock dependency from 1.7.0-rc1 to 1.6.0, which broke support for generics in mocks HOT 1
- How to test an analysis.Analyzer?
- Differentiate compile actions under go_test
- `GoLink` for Gazelle fails on Go 1.20 or greater HOT 2
- goleak broken by recent timeout changes
- How do I depend on the "bazel" package of rules_go when using MODULE.bazel HOT 3
- [BAZEL CI] rules_go cgo:opts_test is failing with Bazel@HEAD HOT 1
- go_tool_binary / GoToolchainBinaryBuild actions don't always run on the correct platform
- GoStdlib, GoCompilePkg, etc. don't respect exec_compatible_with of the underlying C/C++ toolchain HOT 1
- Calls to https://go.dev/dl/?mode=json are breaking airgapped builds - provide way to avoid these HOT 6
- rules_go + protobufs + experimental_sibling_repository_layout fails to build HOT 2
- How do you use protoc with 0.48.0? HOT 4
- Proposal: Fail protoc code gen on missing expected output files
- Embedding native buildinfo in Bazel binaries
- go_proto_library: Issue/New Feature for output path generation.
- How to create go_proto_library automatically HOT 1
- rules_go 0.48.0 inconsistent strict deps behavior between bzlmod enabled and disabled HOT 2
- Cross-compilation to Linux on MacOS sets CGO_ENABLED=0 even though cgo=True in go_library and platform set to linux_amd64_cgo HOT 7
- link: package conflict error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rules_go.