Add direct variables expansion support in oci_push about rules_oci HOT 6 OPEN

Its not a workaround that's how we implemented stamping in rules_oci.

from rules_oci.

I'm not talking about stamping, but just passing a variable to oci_push, eg: bazel run --define=repo_url ...

from rules_oci.

With container_push, we can have the BUILD file:

container_push(
    name = "image-push",
    format = "OCI",
    image = ":image",
    registry = "$(REGISTRY_REGION)-docker.pkg.dev",
    repository = "$(REGISTRY_PROJECT_ID)/dev-repo/myapp",
    tag = "$(IMAGE_TAG)",
    visibility = ["//visibility:public"],
)

and run

bazel run -define=REGISTRY_REGION=us --define=REGISTRY_PROJECT_ID=my-project-id   --define=IMAGE_TAG=test-tag :image-push

I tried below with oci_push but the variable expansion doesn't work.

oci_push(
    name = "image-push",
    image = ":image",
    repository = "$(REGISTRY_REGION)-docker.pkg.dev/$(REGISTRY_PROJECT_ID)/dev-repo/myapp",
    remote_tags = ["$(IMAGE_TAG)"],
    visibility = ["//visibility:public"],
)

The only workaround seems to be using "expand_template" at this time. It would be great if we can add direct variable expansion support in oci_push, like container_push.

from rules_oci.

it's the same thing essentially, expand_template also supports define variables, so you can expand your --define values.

from rules_oci.

Yes, currently since oci_push doesn't support variable expansion, we have to use variable expansion in expand_template to workaround that. Today we use container_push with variables. Is it possible to add variable expansion support in oci_push directly so we don't have to add expand_template for every oci_push during migration?

from rules_oci.

This is by design, is how it works, and not a workaround. Is it unusual? Yes, but it saves us a lot of maintainer time.

we don't have to add expand_template for every oci_push during migration

It's clearly written on the Readme that we are not trying to be 1:1 replacement for rules_docker.

An alternative you can use is that, creating a macro around oci_push that automatically stamps repository and repo_tags so you don't have to use expand template everywhere. It's up to you at that point, how you want to stamp these variables.

from rules_oci.