Giter Club home page Giter Club logo

Comments (3)

guw avatar guw commented on September 26, 2024

Maybe the recommendation should be: don't use this.

I think that's ok. Test execution is easier with Bazel and java_test_suite because one could run all or select them on the command line. There should be no need for @SuiteClasses and @RunWith(Suite.class) anymore.

This might be just a doc issue.

from rules_jvm.

guw avatar guw commented on September 26, 2024

The documentation for java_test_suite is pretty terse.

Specifically this is a tricky point for users (with the example above):

With test_suffixes = ["Test.java", "TestSuite.java"] the type MyTestSuite cannot be compiled

You cannot support both with a single java_test_suite macro call.

from rules_jvm.

tjoneslo avatar tjoneslo commented on September 26, 2024

I never got the Junit5 test suite to compile / run correctly as our use cases never covered it. The closest we got was if you used the Junit @Tag on the tests to define which classes / method you wanted to run with which suite. You could then set the include_tags and exclude_tags on the java_test_suite to select the specific tests.

This would cause a problem if you wanted the same test class in two java_test_suites (presumably with different tags). We solved that by writing a wrapper around the define_test to de-duplicate the names as needed.

It shouldn't be hard to make the JUnit 5 runner support that. It just doesn't at this point.

from rules_jvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.