pre-existing vm.args isn't honored. about cuttlefish HOT 5 CLOSED

Similarly, if you put an old app.config, but not vm.args file it will crash. The conditional use of old-style v. cuttlefish is pinned on the existence on the app.config, it should maybe have another level to the case to separate out the vm.args.

from cuttlefish.

yeah, the heart of the problem is in case filelib:is_file(app.config)

I've been going back and forth on the right way to make this choice. Here's where I'm at now:

If both app.config and vm.args exist in platform_etc_dir, skip the fish

If a .conf file is passed into the escript, and it exists, but either (or both) of the app.config and vm.args are missing, generate new vm.args and app.config, but only start riak with the generated version if the legacy one doesn't exist?

make sense? basically, if we're generating one, we're generating both, but we don't have actually use both.

from cuttlefish.

I think if the app.config is present we should always use it, with warnings / messages printed.

from cuttlefish.

@jaredmorrow yeah, that's what I'm saying, the words just aren't coming out right...

If there's an app.config, use it. If there's a vm.args use it. If either is missing, generate both, but only use the generated one for the one that's missing. If both are missing, use both generated. clearer?

from cuttlefish.

Yes, +1

from cuttlefish.