Comments (5)
Hey @jonnyscholes !
I could add a regex/file extension on the href url, but I don't thing is a good idea.
My doubt is that an URL that ends with .pdf that doesn't necessary means that the file is a pdf.
What is your idea?
(By the way In the next version I'll also make sure to support the download attribute)
from barba.
Supporting the download attribute would be awesome! (I would be happy to submit a PR for this btw). But it doesnt help many users who are stuck with things like TinyMCE which dont (easily) allow adding of attributes/classes to inserted anchor links. For example default Wordpress websites dont allow any changes of anchor HTML at all.
Technically someone could have a link that ends in .pdf (or other file extensions) that returns a valid HTML page - but I would have thought they would be the exception, and not the rule. Most urls that end in .pdf
are a pdf download seeing is a very widely recognized format - along with others like doc
and docx
.
From my point of view it would be more reasonable for people that are returning html from a .pdf
endpoint to override the preventCheck
method than those that are not - as it is a pretty odd thing to do.
We could implement it in a way that is configurable so users can override the formats by doing something like:
Barba.Pjax.start({ignoreFiles: ['pdf', 'doc', 'exe', 'dmg']})
(or similar)
from barba.
Thanks @jonnyscholes .
I'll think about it.
Maybe another solution could be to check the HTTP Content-Type header.
Thanks for the issue!
from barba.
Added support for download attribute in the new version.
965a266
from barba.
I think between the download
attribute and the docs including how one would do this (which it does here) this issue can be closed. I'm more than satisfied as a user :)
from barba.
Related Issues (20)
- Compiling error HOT 1
- Disable `prefetch` on specific links HOT 1
- Maintain element on transition HOT 1
- Typescript issue with documentation example HOT 1
- Page content is duplicated when opened HOT 1
- CSP violation from parseFromString HOT 1
- Back button not working as intended after clicking anywhere on the page HOT 7
- Improve Google Analytics guide in the documentation
- Change the wrapper/container on the fly? HOT 3
- Typescript can't find declaration folder because the name is wrong HOT 5
- Remove polyfill.io from documentation HOT 1
- When linking to pages with hashes, hash does not appear in final URL HOT 2
- OWL Carousel doesn't work HOT 1
- Improve documentation on options to barba.init HOT 4
- External links, checkboxes and radio buttons are not working anymore HOT 12
- Checkboxes not working, and external links are not redirected HOT 3
- Form submissions broken since 2.10.2 HOT 3
- Help! All of my a href https link won't open HOT 5
- Barba breaks when route contains colon and number HOT 3
- Firefox Scroll To Top After Transition Not Working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from barba.