Comments (5)
@Almouro, I think option 2 is the most intuitive. I would even consider disabling autosubmit unless requested (default to submitLastInput: false). Then you could enable it with
const Form = withNextInputAutoFocusForm(View, { submitAfterLastInput: true });
from react-native-formik.
Hi @pzupan, thanks for the issue!
You are not missing anything, https://github.com/bamlab/react-native-formik/blob/master/src/withNextInputAutoFocus.js#L46 is where the last input submits automatically.
I can see 2 possibilities to fix this:
1. Making onSubmitEditing
overridable
it might seem counterintuitive that adding onSubmitEditing
on the wrapped input doesn't override what withNextInputAutoFocus
does in https://github.com/bamlab/react-native-formik/blob/master/src/withNextInputAutoFocus.js#L81.
If we change this and add another callback, aka having:
onSubmitEditing = () => {
if (this.props.onSubmitEditing) this.props.onSubmitEditing();
else this.context.handleSubmitEditing(this.props.name);
};
we could use onSubmitEditing
prop on the last input to prevent the form to be submitted.
2. Adding a configuration the HOC
Something like:
export const withNextInputAutoFocusForm = (WrappedComponent, { submitAfterLastInput } = { submitAfterLastInput: true }) => {
...
if (isLastInput) {
if (submitAfterLastInput) this.props.formik.submitForm();
}
allowing you to do:
const Form = withNextInputAutoFocusForm(View, { submitAfterLastInput: false });
@pzupan Do you have any insight as to what makes more sense to you as a user?
Also @tpucci any possible insight on the subject?
from react-native-formik.
I would go with solution 2 as well 😊
from react-native-formik.
from react-native-formik.
Thanks @pzupan for the PR, I'll close the issue then!
from react-native-formik.
Related Issues (20)
- withNextInputAutoFocus doen't work with custom components at all HOT 3
- Example with the MultiStepWizard (for React Native of course) HOT 1
- Scroll to first invalid element
- Confused by formatting inputs example on home page HOT 2
- Using React Hooks & withNextInputAutoFocus together HOT 4
- [withError] Don't override formik error when error props is defined.
- withNextInputAutoFocusInput goes to next input on new line for a multiline input HOT 2
- Focus next input with custom button HOT 2
- Picker does not appear
- Submission on blur for each individual input should be an optional configuration HOT 1
- Custom input with initial value is not working
- Update peer dependency version to allow Formik 2.0 HOT 3
- handleTextInput() throws error when not wrapped in Formik component
- TypeError: undefined is not an object (evaluating '(i === 0 ? obj : resVal)[pathArray[i]]') HOT 4
- withNextInputAutoFocus doesn't work with FlatList
- react-native-formik throws an error and doesn't work AT ALL with Formik v2 HOT 6
- doesn't work in react-native 0.63.2
- WithNextInputAutoFocusInput Formik children is not updating
- Nested Form Walkthrough
- TypeError: undefined is not an object (evaluating '(i === 0 ? obj : resVal)[pathArray[i]]') HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-formik.