Giter Club home page Giter Club logo

Comments (5)

pzupan avatar pzupan commented on September 28, 2024 1

@Almouro, I think option 2 is the most intuitive. I would even consider disabling autosubmit unless requested (default to submitLastInput: false). Then you could enable it with

const Form = withNextInputAutoFocusForm(View, { submitAfterLastInput: true });

from react-native-formik.

Almouro avatar Almouro commented on September 28, 2024

Hi @pzupan, thanks for the issue!

You are not missing anything, https://github.com/bamlab/react-native-formik/blob/master/src/withNextInputAutoFocus.js#L46 is where the last input submits automatically.

I can see 2 possibilities to fix this:

1. Making onSubmitEditing overridable

it might seem counterintuitive that adding onSubmitEditing on the wrapped input doesn't override what withNextInputAutoFocus does in https://github.com/bamlab/react-native-formik/blob/master/src/withNextInputAutoFocus.js#L81.

If we change this and add another callback, aka having:

onSubmitEditing = () => {
      if (this.props.onSubmitEditing) this.props.onSubmitEditing();
      else this.context.handleSubmitEditing(this.props.name);
    };

we could use onSubmitEditing prop on the last input to prevent the form to be submitted.

2. Adding a configuration the HOC

Something like:

export const withNextInputAutoFocusForm = (WrappedComponent, { submitAfterLastInput } = { submitAfterLastInput: true }) => {
   ...

   if (isLastInput) {
        if (submitAfterLastInput) this.props.formik.submitForm();
   }

allowing you to do:

const Form = withNextInputAutoFocusForm(View, { submitAfterLastInput: false });

@pzupan Do you have any insight as to what makes more sense to you as a user?
Also @tpucci any possible insight on the subject?

from react-native-formik.

tpucci avatar tpucci commented on September 28, 2024

I would go with solution 2 as well 😊

from react-native-formik.

pzupan avatar pzupan commented on September 28, 2024

Pull Request

from react-native-formik.

Almouro avatar Almouro commented on September 28, 2024

Thanks @pzupan for the PR, I'll close the issue then!

from react-native-formik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.