Bug: shell and indexquestion do not work on nixos about butterfish HOT 4 CLOSED

Ok this should be fixed now in the v0.1.4 release - I definitely misunderstood the issue initially, thanks for investigating @bhazzard

from butterfish.

Hey @tompflynn - thanks for creating an issue, sorry this isn't working as expected. I'm going to try to reproduce the error right now.

One theory I have about the shell problem is that this code added recently is causing the problem. If that's the case a workaround would be to try running butterfish shell -p'' to see if that makes a difference.

Something that would be helpful - what's in your .bashprofile or .profile? I haven't seen anything like this on a handful of different shells so I'm wondering if there's some more custom/esoteric setup happening.

from butterfish.

Spun up a NixOS, wasn't able to replicate. My best guess is there's something a bit custom going on in a file that bash is loading like .bashprofile or .profile.

from butterfish.

To show what the ux seems to be on Mac using zsh...

Loading the index seems to work as expected

$ butterfish loadindex .

Loading indexes (not generating new embeddings) for .
Loaded 56 files

...But asking a question fails, claiming no index is loaded

butterfish indexquestion "is this working?"

Error: No vector index loaded

... Interestingly, indexsearch works just fine

butterfish indexsearch "is this working?"

/butterfish_index_test/testfile.txt : 0.8021
test content to diagnose index issue on Mac

...A quick look at the code

That error message in indexquestion comes from: https://github.com/bakks/butterfish/blob/f790d7d0aeb8e6520837b61ba7bfe40b53570697/butterfish/commands.go#L362-L364C4

  if this.VectorIndex == nil {
          return errors.New("No vector index loaded")
  }

...comparing the working command indexsearch with indexquestion

We can see that the first thing the indexsearch command (which works) does is this.initVectorIndex(nil), whereas indexquestion command seems to skip this step. My guess is that this is the culprit. But why would this work for some folks?

... but when I make that change (add this.initVectorIndex(nil)), I get a new error

Error: Incorrect number of fields provided, prompt question requires fields ({filename}, {snippets}, {question})

This comes from:

// check that the number of fields matches the number of arguments
if len(fields)*2 != len(args) {
        fieldNames := strings.Join(fields, ", ")
        return "", fmt.Errorf("Incorrect number of fields provided, prompt %s requires fields (%s)", prompt.Name, fieldNames)
}

When it is trying to load the prompt for "question".

from butterfish.