Giter Club home page Giter Club logo

Comments (6)

YenHub avatar YenHub commented on May 10, 2024

@bahmutov - is this by design or can I open an MR to address this?

from npm-install.

bahmutov avatar bahmutov commented on May 10, 2024

from npm-install.

YenHub avatar YenHub commented on May 10, 2024

I have opened a pull request which hopefully addresses this issue.

Let me know how it goes!

#102

from npm-install.

simonihmig avatar simonihmig commented on May 10, 2024

@YenHub Thanks for tackling this! I have finally tried this, but still see the same (wrong) behavior (see https://github.com/kaliber5/ember-stargate/pull/322/checks?check_run_id=3905655494#step:4:40).

However it seems to me the action is not actually using the latest code, as the dist/index.js files has been last updated 9 month ago! @bahmutov seems your automated publishing workflow isn't compiling the action automatically, so how is this supposed to work?

Another point: I think for the lockfile to be ignored, yarn has to run with the --no-lockfile option. So shouldn't this line be like follows?

const args = shouldUsePackageLock ? ['--frozen-lockfile'] : ['--no-lockfile']

from npm-install.

YenHub avatar YenHub commented on May 10, 2024

Thanks @simonihmig for your update

RE:

const args = shouldUsePackageLock ? ['--frozen-lockfile'] : ['--no-lockfile']

Where an empty array is passed into exec as args, no args are presented, therefore Yarn will run with it's default behaviour, that is, no lock file behaviour.

You effectively end up with:-

return exec.exec(quote(yarnPath), [], options)

from npm-install.

simonihmig avatar simonihmig commented on May 10, 2024

Where an empty array is passed into exec as args, no args are presented, therefore Yarn will run with it's default behaviour, that is, no lock file behaviour.

I understand that, but the default behavior of yarn is to take the lockfile into account!? (at least that is for yarn v1)

from npm-install.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.