Comments (6)
@bahmutov - is this by design or can I open an MR to address this?
from npm-install.
from npm-install.
I have opened a pull request which hopefully addresses this issue.
Let me know how it goes!
from npm-install.
@YenHub Thanks for tackling this! I have finally tried this, but still see the same (wrong) behavior (see https://github.com/kaliber5/ember-stargate/pull/322/checks?check_run_id=3905655494#step:4:40).
However it seems to me the action is not actually using the latest code, as the dist/index.js
files has been last updated 9 month ago! @bahmutov seems your automated publishing workflow isn't compiling the action automatically, so how is this supposed to work?
Another point: I think for the lockfile to be ignored, yarn
has to run with the --no-lockfile
option. So shouldn't this line be like follows?
const args = shouldUsePackageLock ? ['--frozen-lockfile'] : ['--no-lockfile']
from npm-install.
Thanks @simonihmig for your update
RE:
const args = shouldUsePackageLock ? ['--frozen-lockfile'] : ['--no-lockfile']
Where an empty array is passed into exec
as args, no args are presented, therefore Yarn will run with it's default behaviour, that is, no lock file behaviour.
You effectively end up with:-
return exec.exec(quote(yarnPath), [], options)
from npm-install.
Where an empty array is passed into exec as args, no args are presented, therefore Yarn will run with it's default behaviour, that is, no lock file behaviour.
I understand that, but the default behavior of yarn
is to take the lockfile into account!? (at least that is for yarn v1)
from npm-install.
Related Issues (20)
- Make action fault-tolerant when using caching
- v1.8.16 breaks cache miss installs when the yarn cache dir != ~/.yarn/cache (windows, yarn2+, etc.) HOT 17
- [Feature request] Add action typings HOT 2
- Investigate the warnings HOT 1
- Github workflow fails at bahmutov/npm-install@v1
- Cache hit- but still installs dependencies HOT 3
- "npm cache hit undefined" HOT 12
- support for install with legacy peer dependencies HOT 2
- workflow main fails
- can't find the package.json file
- npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]
- Ability to swap out actions/cache for the faster alternative buildjet/cache
- [bug] cache not work in windows
- --frozen-lockfile deprecated, add --immutable option
- Action tied to Node.js 16 with end-of-life on Sep 11, 2023 HOT 4
- useYarn input is missing from action.yml
- My Google Chrome Browser is "This redirect failed because the redirect URI is not whitelisted in the app’s Client OAuth Settings"
- figure out the source of the error HOT 2
- Add cache key prefix HOT 1
- Performance problem HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from npm-install.