Giter Club home page Giter Club logo

Comments (4)

bbonet-levelsbeyond avatar bbonet-levelsbeyond commented on May 23, 2024

Dude. You're a monster.

from isthereafuckinggame.

baer avatar baer commented on May 23, 2024

It turns out that EDT (what the MLB uses) is not a unique timezone. It also specifically does not obey daylight savings time so it's been a little trickier than I thought.

@bbonet-levelsbeyond is this your fork? I am about to do a huge rev which will have dramatically better mobile perf. Just an FYI, it's mostly done and will get merged to master in the next day or two.
https://github.com/bbonet/isThereAFuckingGame

from isthereafuckinggame.

bbonet avatar bbonet commented on May 23, 2024

I'm just commenting on your general activity. ;-) Of course, this is the
problem with trying to auto ingest the schedule. When I did
isthereafuckingavsgame it was a bit different, so it wouldn't surprise me
that the schema could change on a whim. Granted that risk is once per
season.

On Mon, May 11, 2015 at 6:08 PM, Eric Baer [email protected] wrote:

It turns out that EDT (what the MLB uses) is not a unique timezone. It
also specifically does not obey daylight savings time so it's been a little
trickier than I thought.

@bbonet-levelsbeyond https://github.com/bbonet-levelsbeyond is this
your fork? I am about to do a huge rev which will have dramatically better
mobile perf. Just an FYI, it's mostly done and will get merged to master in
the next day or two.
https://github.com/bbonet/isThereAFuckingGame


Reply to this email directly or view it on GitHub
#9 (comment)
.

from isthereafuckinggame.

baer avatar baer commented on May 23, 2024

Sorry for the delay but, I've done an almost-complete rewrite and I'm using moment-tz to handle it. I know, I know I should be using Luxon or date-fns, or some other lib that takes advantage of Intl but, Moment was what I had in that moment (get it!). The relevant code is in the Schedule converter and it's a bit ugly but, it'll do. PRs welcome. Not sure yet if this breaks based on DST but, we'll see.

Let's just all prey that the [Sunshine Protection Act of 2021](https://www.congress.gov/bill/117th-congress/senate-bill/623/text) finally gets written into law and all this silliness can be over.

    const date = moment.tz(
      `${game["START DATE"]} ${game["START TIME ET"]}`,
      "MM/DD/YY hh:mm a",
      "America/New_York"
    );

from isthereafuckinggame.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.