Comments (5)
kasium
commented on July 22, 2024
Hi,
just found this issue. I guess making the paths as diff-cover needs them is not too complicated. I see this on our side since eslint refuses to support relative paths in reports (eslint/eslint#13376).
My approach would be:
- Make the paths relative to the got repository
- In the case the report was generated on another machine, the part which we want to remove can differ. Therefore a new cli parameter defining the "root" could help
Report
/root/git/repo/a.js: foo
Same machine: Our git path would be "/root/git/repo" --> a.js
Other machine with the path /usr/foo/git/a.js --> diff-quality --violations eslint --repo-path "/root/git/repo" report.txt --> a.js
@Bachmann1234 what do you think about this? Any suggestion for the cli name?
from diff_cover.
Bachmann1234
commented on July 22, 2024
maybe 'base-path' ? or 'root-path'? Or maybe 'repo-root'. Something to imply a root right?
from diff_cover.
kasium
commented on July 22, 2024
@Bachmann1234 I'm sorry for the late follow-up. Currently I stuck how to give the root_path to the quality driver w/o breaking the API of the quality driver.
I cannot give it in the constructor since it's defined in the CLI, but also the parse_reports doesn't work w/o adding another pameter.
Any idea?
from diff_cover.
Bachmann1234
commented on July 22, 2024
Is adding an optional kwarg not an option?
IF we wanna break the api a bit I wanna say its possible. I have not gotten
signals that many people have made plugins. I think we could just contact
the SQLFluff project and either provide them a PR or just coordinate.
When we release this i'll increment a major version.
…-Matt Bachmann
On Fri, Sep 3, 2021 at 7:17 AM kasium ***@***.***> wrote:
@Bachmann1234 <https://github.com/Bachmann1234> I'm sorry for the late
follow-up. Currently I stuck how to give the root_path to the quality
driver w/o breaking the API of the quality driver.
I cannot give it in the constructor since it's defined in the CLI, but
also the parse_reports doesn't work w/o adding another pameter.
Any idea?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#81 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTLRJPGRRMPZYSTPRR7J3UACVEPANCNFSM4FRNH2JA>
.
from diff_cover.
Bachmann1234
commented on July 22, 2024
Try out https://pypi.org/project/diff-cover/6.4.0/ thanks @kasium for the PR !
from diff_cover.
Related Issues (20)
- Blank lines not factored into range HOT 2
- Few tests fails in rmtree HOT 6
- 7.3.1: test suite is failing in `tests/test_integration.py::TestDiffQualityIntegration::test_html_with_external_css` unit HOT 2
- Make chardet a optional dependency HOT 1
- In cpp file，The coverage of changed lines is not being counted HOT 2
- any ways to get all measured lines' numbers from json report HOT 2
- Feature request — Invert output to find flaky tests and help determine test failures HOT 1
- does this tool support C++ opencppcoverage? cppcoverage has html, cobertura reports. HOT 1
- urgent！！ work environment！！No lines with coverage information in this diff. HOT 2
- new Github action for diff-cover HOT 1
- There is a folder code that cannot be counted. It has been analyzed for a long time, please help HOT 1
- 5 tests fail HOT 2
- Package has classifier "License :: Other/Proprietary License" - raising licensing flags for Sonatype HOT 3
- Enhancing Report Visualization in 'diff-cover' Project for Improved Code Analysis HOT 2
- 7.7.0: pytest is failing in `tests/test_violations_reporter.py::TestFlake8QualityReporterTest::test_file_does_not_exist` unit HOT 33
- Support ruff for quality checking HOT 1
- diff everything on removal HOT 11
- Diff between two coverage files instead of coverage file from branch HOT 2
- Running diff-quality with a tool which is not installed gives FIleNotFoundError rather than helpful "<tool> is not installed" error message HOT 2
- Add support for Pyright as a quality-checking tool HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diff_cover.