Clearly demonstrate diff-cover is language indepenedent about diff_cover HOT 15 CLOSED

Sounds good y'all. A while back I refactored a bunch of stuff to make plugins (or I guess config) possible. But never actually did step 2 of making the plugin setup (or config file).

At this point im mostly a maintainer rather than actively developing this. Triaging and reviewing. So if yall go for it absolutely go for it :-)

from diff_cover.

Part of 'solving' this issue is that diff-quality needs a plugin system rather than just embedding each tool

from diff_cover.

Maybe a config file would be enough?
Tool configuration consists only of three strings after all (in most cases).

from diff_cover.

@dreamwalker is is true for many tools. But pylint, for example, needs more than that. Other tools may do all sort of wild things.

from diff_cover.

So, maybe two solutions? Plugins for complex cases, config for simplier?
We could then move the current configs to example config files.
Also - as I can see, pylint needs additional code because of multi-line violations. Maybe we could move it to the main class to support other checkers with this kind of logs?
And by we I mean I also can do it :) (e.g. during this weekend).

from diff_cover.

Perhaps! I have not moved forward on this because I have not needed any additional checkers. If you got the drive to whip something up ill absolutely look at it and consider merging it in.

I suspect we may have to leave the existing items in as is to we dont break things for existing users. But who knows!

from diff_cover.

Let me know if I can help - I have diff-cover working with Rails projects, using simplecov and simplecov-cobertura.

from diff_cover.

Does the tool work on Java code? Can we clearly call that out on the README?

from diff_cover.

The tool should work on Java code.

I think the readme/docs need an overhaul as a lot has been added and I think the docs could use some love

from diff_cover.

If I do try it with my Java code, I’ll submit a pr. Thanks for sharing this code!

from diff_cover.

I'm helping with the testing, documentation, and development of a SQL linter package called SQLFluff. It is implemented in Python. Would you consider merging a PR to add support for it in diff-quality?

from diff_cover.

from diff_cover.

Thanks! I will also look into implementing a plugin system. I have used a package called Pluggy which makes this pretty easy.

from diff_cover.

Can this ticket be closed now?

from diff_cover.

Closing this with https://pypi.org/project/diff-cover/2.5.0/ thanks @barrywhart

from diff_cover.