Add lang="typescript" to templates about sapper-typescript-graphql-template HOT 8 CLOSED

Looks like the only place this hasn't happened yet is index.svelte which I just recently fixed in the derivative but forgot to do again here. Maybe I can fix that right after dinner in ~20 minutes. Thank you.

from sapper-typescript-graphql-template.

Oh cool. I actually hadn't opened the other files and didn't realize they were already updated :-)

I wonder if it'd be better to just set "noUnusedLocals": false and remove most of the // @ts-ignore

from sapper-typescript-graphql-template.

It's claimed svelte-preprocess won't support that https://github.com/sveltejs/svelte-preprocess#typescript

Edit: It doesn't in the override / merge options, but it does in the global tsconfig.json file.

from sapper-typescript-graphql-template.

Actually, I think it would be a better idea to globally disable that and leave it to ESLint.

from sapper-typescript-graphql-template.

Probably closed by cc679eb

from sapper-typescript-graphql-template.

Just FYI, I think that the only reason the templates in this repo are able to be written in TypeScript is that they don't have preload functions. I have a PR pending in the Sapper repo that will fix an issue there to allow you to write preload functions in TypeScript-based Svelte templates.

You can probably still go ahead and use TypeScript in the templates since you don't have preload functions, but I thought I'd give you a heads up in case you run into any issues trying to add a preload

from sapper-typescript-graphql-template.

Thank you for reminding me. I remember historically having to write context="module" parts of the script in regular JS, but I don't know if any changes since then have allowed TS there yet.

from sapper-typescript-graphql-template.

closed by #11 (sapper 0.28) 😄

from sapper-typescript-graphql-template.