Comments (5)
Hey @qtiki! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.
If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.
from minify.
It seems that @babel/traverse
v7.17.10 has only this one commit which is probably the cause for this - or then the minify plugin needs to be updated somehow to accommodate for these changes (I'm not a Babel developer so I have no clue). FYI @JLHwung
from minify.
Thanks for the report. This issue should be fixed in the minify plugin.
minify/packages/babel-plugin-minify-dead-code-elimination/src/index.js
Lines 357 to 359 in 1ad7838
Before v7.17.10 Babel does not report this
as a pure expression, so dce will not try to remove _this = this
. However, after 7.17.0 we should check whether the original non-arrow scope is same with the replacement non-arrow scope. If they are same, we can safely replace _this
by this
, otherwise we should bail.
from minify.
Note that deadcode
also suffers from #981, so I'd recommend simply disabling it (along with simplify
for #999 and builtIns
for #904 if you run into it).
Unfortunately this project appears to be unmaintained (the last commit was in August of 2020), so looking into other minifiers might also not be a bad idea.
from minify.
Unfortunately this project appears to be unmaintained (the last commit was in August of 2020), so looking into other minifiers might also not be a bad idea.
This is quite bad. We have a build pipeline that relies on minify-replace
and minify-dead-code-elimination
working in tandem to have different compile targets. It's quite critical to us so just disabling deadcode elimination is not an option. I'll look into other options but basically this means that we'll need to stick to an older Babel version until we can work out a replacement.
from minify.
Related Issues (20)
- Keeping line breaks in the transformed code HOT 1
- ReactNativeJS: ReferenceError: Can't find variable: error
- Using minify get an endless loop of code
- After executing my plug-in after the minify-dead-code-elimination, I still get the deleted dead code in my plug-in
- Feature request: Convert long repeated strings to `.repeat()` when minifying
- asm.js code minified with babel-plugin-minify-dead-code-elimination causes "asm.js type error: initializer of exported object literal must be name of function" error in Firefox
- babel-plugin-minify-dead-code-elimination fails to remove variable declaration after return statement
- babel-plugin-minify-dead-code incorrect when var inside if
- minify-mangle-names fail when default parameters are assigned to a variable
- Constant with regular expression literal with global modifier incorrectly replace by literal
- Can't install babel-plugin-transform-remove-console getting unable to resolve dependency tree error
- Remove dependency badges
- [Bug] DCE is failed with block expression HOT 3
- Cannot read property 'add' of undefined while parsing file HOT 1
- Keep arguments name
- babel-plugin-minify-mangle-names doesn't rename calls in JSX expressions after mangling the variable name
- babel minify output has mysterious/broken output for this example HOT 1
- merge-sibling-variables loses source mapping
- [Bug]: The code cannot be minimized. There are two references HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minify.