Comments (6)
This is probably true for other keywords as object keys like say function
then right?
from babylon.
yeah
from babylon.
It is a keyword though, right? It's just that in this instance, a keyword is allowed as a name, it doesn't make the token less of a keyword token.
from babylon.
Keyword token plays role of a keyword. In this case it's just an identifier.
from babylon.
I'd say it is a matter of interpretation - like in ast it is definitely an identifier, whereas in tokens list it is could be interpreted as keyword (and might be useful in some situations), although, tokens are needed to do an ast and it is pretty hard to distinguish it from other entities, since those and this token are identical, so we would need to analyze the surroundings and stuff. On the other hand other tokenizers consider this a keyword.
I think everybody would win if we would add a clarifier - another flag, property. As a bonus no one would consider this a breaking change, if that sounds acceptable we can provide a pr btw.
Also, on the side note - i think for the case like
({ "something": 1 })
keyword
property for something
token shouldn't be an undefined
but false
?
from babylon.
This issue has been moved to babel/babel#6724.
from babylon.
Related Issues (20)
- Can't use object-rest-spread in a function HOT 6
- Should we allow Flowtype `import type` statements when `sourceType:script`? HOT 2
- How to get the "root" path HOT 5
- ES2016 bind syntax does not work with functions HOT 5
- Flow interfaces & `declare class` do not adhere to ASI HOT 2
- Warning if tests fail that if you need to generate fixtures. HOT 2
- React 16 SyntaxError: Adjacent JSX elements must be wrapped in an enclosing tag HOT 7
- Set id to null for ArrowFunctionExpressions? HOT 3
- babylon super.xxx will cause performance is very slow HOT 1
- Add sourceType 'function' HOT 12
- Typescript: ExportNamedDeclaration raises SyntaxError when exportExtensions plugin enabled HOT 1
- Unable to parse a class get method with a decorator HOT 2
- static field initializer as an arrow function containing new.target is not allowed
- Unexpected AST for pipeline operator with arrow function HOT 2
- Flow comment parsing HOT 8
- typescript: Support binding pattern in signature HOT 2
- Existential return type annot in arrow function confused with `*=` operator HOT 5
- Error w/ generics in return type annots inside JSXExpressionContainers HOT 3
- [Presets: React + Typescript] Complex method with generic type fails during transpilation HOT 2
- PSA: this repo has been moved to the main babel repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babylon.