`BatchRenamer`, 100x faster `scope.rename` when you have many identifiers to rename about babel HOT 6 OPEN

Thanks for this!

Maybe we could make rename accept an array of string | string[]?

from babel.

Hey @remorses! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

from babel.

In my code I used a Map that goes from old names to new names. I am not sure if this feature would be used enough and if it would make sense to add to babel core

from babel.

We would at least use it in the commonjs transform, where we rename multiple identifiers one after the other, and probably in the let/const transform where we can batch-rename variables when converting them to var.

from babel.

Why is a full traverse needed in the first place? Got a massive performance boost by looping over binding.referencePaths/constantViolations instead (without batching)

from babel.

Why is a full traverse needed in the first place? Got a massive performance boost by looping over binding.referencePaths/constantViolations instead (without batching)

Because binding.referencePaths/constantViolations may be inaccurate, using them may have some risks.

from babel.