targets property only accepts object about babel-polyfills HOT 3 CLOSED

Thanks for the report! I opened ad PR to allow strings.

I thought the goal of babel-polyfills is to get rid of all this?

Yes and no. The goal of babel-polyfills is to avoid injecting imports to unnecessary polyfills. However, if a modern polyfill includes an import to some legacy code, there is nothing that we can do about that.

Atm, the compiled file is actually bigger than what I had before.

Is this compared to core-js 3 with preset-env, or to core-js 2? In the first case it's unexpected, in the second case is because core-js@3 handles many more edge cases.

from babel-polyfills.

Just got the same error when passing string targets to polyfill-regenerator too. polyfill-regenerator doesn't even seem to support targets per #36 , but still gets the error, so that makes me think it's a bug in the shared helper all the polyfill plugins use, @babel/helper-define-polyfill-provider.

It also uses @babel/helper-compilation-targets which is used in @babel/preset-env, so it's gotta be somewhere in between then. I think the bug would be in this file, but not totally sure.

from babel-polyfills.

Is this compared to core-js 3 with preset-env, or to core-js 2? In the first case it's unexpected, in the second case is because core-js@3 handles many more edge cases.

Compared to core-js 3

Yes and no. The goal of babel-polyfills is to avoid injecting imports to unnecessary polyfills. However, if a modern polyfill includes an import to some legacy code, there is nothing that we can do about that.

Is it true that since the polyfill has access to targets now, it should not ship code which is not required? If so, I guess polyfill write needs to catch up first, right?

from babel-polyfills.