Comments (5)
borkdude
commented on May 26, 2024
1
Yep, that would be it, PR welcome
from babashka.
borkdude
commented on May 26, 2024
1
Not necessary but if you want the assurance you could just add one to
interop tests to see if your code works
ā¦On Fri, 1 Dec 2023 at 22:10, paintparty ***@***.***> wrote:
Would this addition to the :instance-checks require adding a unit test,
as mentioned in the Adding classes
<https://github.com/babashka/babashka/blob/master/doc/dev.md#adding-classes>
section of the dev.md doc? If so, where should it go? Asking because I
can't seem to find unit tests for some of the other things in
:instance-checks.
ā
Reply to this email directly, view it on GitHub
<#1645 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFSBQTQ5TX6TT3ODULB7DYHJBTPAVCNFSM6AAAAABADMESQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZWG44DCMBSGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
from babashka.
paintparty
commented on May 26, 2024
Would this addition to the :instance-checks require adding a unit test, as mentioned in the Adding classes section of the dev.md doc? If so, where should it go? Asking because I can't seem to find unit tests for some of the other things in :instance-checks.
from babashka.
borkdude
commented on May 26, 2024
PR still welcome, or no longer needed?
from babashka.
paintparty
commented on May 26, 2024
Thank you for the reminder, just created a PR.
from babashka.
Related Issues (20)
- Command line parameters not being parsed by scripts, passing right through if Babashka has the same ones. HOT 2
- Change in v1.3.187 release breaks use of the `version` literal as an input to scripts
- Caching issue with relative local/root by same name, used in bb.edn in different directories HOT 1
- Resolve bb.edn when script is invoked via symlink HOT 1
- No dispatch macro for: ? HOT 9
- metadata added by read-string (as compared to clj implementation). HOT 9
- Embedding META-INF/bb.edn with :deps results in: Cannot run program "java"
- bb execution fails on Gentoo HOT 6
- Adding javax.net.ssl.SSLSocket and javax.net.ssl.SSLSocketFactory? HOT 33
- Static-linked binary file for armv7(32-bit) platform. HOT 1
- hash-ordered-coll not found in clojure.core HOT 1
- Try to support latest changes in at-at
- Wrapping built-in timbre/log! throws an error HOT 3
- exec-task description
- bb --version could run without a JVM HOT 1
- Can't use a lambda in a babashka's task HOT 2
- Babashka's `use-fixtures` doesn't add `:clojure.test/*-fixtures` metadata to namespace
- Dynamic var *test-out* not properly bound when clojure.test is called from within the nrepl
- bb should error when bb.edn does not contain exactly one valid form HOT 2
- Feature request: Expose flatland.ordered.set/ordered-set HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babashka.