StackOverflowError on 1.3.186 but script properly working with 1.3.185 about babashka HOT 6 CLOSED

Strangely when I change the filter-empty-dirs function by adding a println at the start of its second header it works well with both babashka versions:

(defn filter-empty-dirs
  ([entries]
   (let [groups (group-by #(dir? %) entries)
         dirs (map #(.path %) (groups true))
         files (map #(.path %) (groups false))]
     (filter-empty-dirs files dirs)))

  ([files dirs]
   (println (count files) (count dirs))  # This line makes it work
   (if (empty? files)
     dirs
     (let [[current-file & rest-files] files]
       (->> dirs
            (remove (path-components current-file))
            (recur rest-files))))))

from babashka.

I am repro-ing with docker with 1.3.185 and it also gives an SO:

docker run --rm -v $(pwd):/tmp babashka/babashka:1.3.185  bash -c 'cd /tmp; bb files.clj'

You can fix this by making remove strict before doing the recur:

(defn filter-empty-dirs
  ([entries]
   (let [groups (group-by #(dir? %) entries)
         dirs (map #(.path %) (groups true))
         files (map #(.path %) (groups false))]
     (filter-empty-dirs files dirs)))

  ([files dirs]
   (if (empty? files)
     dirs
     (let [[current-file & rest-files] files]
       (->> dirs
            (remove (path-components current-file))
            vec
            (recur rest-files))))))

from babashka.

Thnks!!!!

from babashka.

Strangely it does not fail for me when I use 1.3.185 docker image as you do. But it does when I use 1.3.186.

https://asciinema.org/a/1CqV7e3aLnpLMqeSvwIbccpmt

from babashka.

It could be that the stack size is slightly different in your case, but lazy expression don't mix well with deeply recursive code and is known to cause such problems sooner or later.

from babashka.

Great!!! Thank you for your patience.

from babashka.