Giter Club home page Giter Club logo

Comments (12)

achimfritz avatar achimfritz commented on July 20, 2024 2

@ttg-team-web can you test 2b6917c

from container.

achimfritz avatar achimfritz commented on July 20, 2024

@ttg-team-web can you please describe, how i can reproduce this issue on a Vanilla TYPO3 + container?

from container.

ttg-team-web avatar ttg-team-web commented on July 20, 2024

we are working with mask for out content elements but this behaviours has also been tested and replicated with native typo3 elements like "text":

  • create a container
  • create an element in the container
  • in the backend view / page module drag and drop the element into another container or column
  • reload the site / backend view
  • element should now be in the unused section and when edited "colpos" and "tx_parent_grid" should be filled as above

from container.

TonyMarc avatar TonyMarc commented on July 20, 2024

I second this issue with a vanilla TYPO3 v12.4.6. Content elements can be created in container just fine but after dragging and dropping them into another container (and a page reload), they become unused elements.
unused

from container.

achimfritz avatar achimfritz commented on July 20, 2024

@ttg-team-web , mh, this works for me, (and should work in general), there is also a Test-Case for this Scenario (https://github.com/b13/container/blob/master/Tests/Acceptance/Backend/LayoutCest.php#L160)

i see a very large integer value of colPos in your screenshot, maybe there is a problem with the delimiter in V12
https://github.com/b13/container/blob/master/Classes/Backend/Grid/ContainerGridColumn.php#L23
can you give me your uids from all relateded DatabaseRecords (pages, tt_content), do you have very large uids? (max(uid) from tt_content/pages?), this could be an explanation of your described scenario (maybe i can increase the CONTAINER_COL_POS_DELIMITER_V12 constant)

from container.

ttg-team-web avatar ttg-team-web commented on July 20, 2024

@achimfritz i don't believe the uids themselves are the issue, like i said in my original message, i believe the casting of the string containing coontainer-id + new delimiter + colpos to integer is not working correctly. this is done here https://github.com/b13/container/blob/master/Classes/Backend/Grid/ContainerGridColumn.php#L46

nonetheless here are the uids involved in my test above:

  • pages uid: 5 > max uid 38487
  • container uid: 130881
  • tt_content uid: 130882 > max uid 270740

so yes we have very high uids, but since @TonyMarc could replicate the problem on a vanilla installation...

from container.

achimfritz avatar achimfritz commented on July 20, 2024

@ttg-team-web , ok, thanks, your uids are all < 999990, so should be no problem.

what exactly do you meen, with "casting of the string containing coontainer-id + new delimiter + colpos to integer is not working correctly"? how can this not be correctly? (all 3 parts are integers, right?).

Please give me more hints, how this is reproduceable

from container.

ttg-team-web avatar ttg-team-web commented on July 20, 2024

@achimfritz all 3 parts should be integers yes, but in the getDataColPos() function all three parts are combined into one string and then cast to integer. this results in the string of numbers that you see above in my screenshot in the colpos field. so something is not correct here.

as a test i printed the combined container-id + new delimiter + colpos string and the result when you cast it to integer in the getDataColPos() function.
see here different strings that all return the same result when cast.

image

does this help/make my point a bit clearer. this is about as far as i went into the container code before i made my issue here.

from container.

achimfritz avatar achimfritz commented on July 20, 2024

@ttg-team-web ah, i think i got it, you have 32bit system? (where PHP_INT_MAX is 2147483647)

from container.

ttg-team-web avatar ttg-team-web commented on July 20, 2024

@achimfritz yes, our local environment is a 32bit system. checking PHP_INT_MAX confirmed it, it is indeed set to that value (2147483647)

from container.

wolfhoel avatar wolfhoel commented on July 20, 2024

@achimfritz i've tested 2b6917c and now everything works as expected. Thank you! Btw I'm a member of ttg-team-web :-)

from container.

ttg-team-web avatar ttg-team-web commented on July 20, 2024

@achimfritz can confirm that bugfix 2b6917c works as well. thanks!

from container.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.