Menu padding issues in gtk3 menuitems in xfce 4.12 about chrome-os HOT 23 CLOSED

@gps08 screenshot comparing with another theme please?

from chrome-os.

with default greybird theme:

with chrome-os theme

from chrome-os.

this is a weird issue we've been having. I haven't been able to find a solution for now. What's even weirder is the icons do appear on certain apps.

will check greybird code

from chrome-os.

i think its the apps that use gtk3.2 in particular

from chrome-os.

@gps08 I think I found the bug. I'm missing min-height/width for menuitemm check/radio

can you try to add min sizes on your side and see if it works? I'm unavailable to test for the moment

from chrome-os.

@gps08 applied and pushed fix, at least for check radio buttons

from chrome-os.

@Elbullazul yes this fixes the issue, thanks

I think the spacing can be a little better though

from chrome-os.

reduced spacing by 3px

cheers

from chrome-os.

i meant horizontal spacing, but the one in the commit changes the vertical one

from chrome-os.

@gps08 like I said in the commit, I got my CSS messed up a bit. I'm restoring padding to 6px 8px

pushed changes in 656f510

from chrome-os.

it should work fine this time with 8689082

from chrome-os.

@Elbullazul actually its still not okay

the entry with the checkbox is lot more thicker than the other ones

from chrome-os.

@gps08 what version of Xfce are you using and how could I get it? on my arch VM I still have mousepad GTK2

from chrome-os.

@Elbullazul its xubuntu 17.04, heres a link
i think it ported to gtk 3.2 just recently

from chrome-os.

@gps08 I have to keep the padding like this, since nemo breaks if it's not set this way:

and mousepad is still not complete, so it may have something to do.

or I could reduce radiocheck size, I'll evaluate fixes

from chrome-os.

u sure that nemo uses gtk3.2??

from chrome-os.

yes, it uses the installed GTK 3 toolkit

but you see that in nemo the check is smaller than in mousepad, so maybe I can have the mousepad check size reduced

what do you think?

from chrome-os.

the xfce-panel wifi menu also shows the same problem as in mousepad, so i am thinking its a global problem

from chrome-os.

try moving the gtk3.2 folder and see if that breaks the nemo menuitems, i think it must be using gtk3.0 folder of the theme rather than gtk3,2

from chrome-os.

@gps08 no, Nemo uses 3.20. You can't have 3.18 and 3.20 apps running together at the same time, since GTK MUST ONLY be installed once on a system, else there's big problems

also, I fixed the check in nemo tweaking the 3.20 gtk-widgets.css, so it's obvious it uses 3.20

from chrome-os.

@Elbullazul okay, but i have 3 apps that i can pinpoint having this problem..

from chrome-os.

@gps08 maybe I got messed up with my words.

I was saying that Nemo has weird placing issues with the radiocheck items. I acknowledge the Xfce bugs too, I was just pointing the fact that Xfce is not the only platform affected.

now, since the check-radio icons are 16x16, it needs bigger margins to stay aligned in nemo and other apps. So the only way of fixing this for all current and future apps is to reduce the check-radio size to, say, 10x10. I will test this and I installed Xubuntu in a VM, so I'll be able to live-test results.

I'll post as soon as I push modifications. Thanks again for your help

from chrome-os.

@Elbullazul yes 10x10 works on my desktop, and looks good too.
take your time to commit it, and thanks for clarifying

from chrome-os.