The value of SHA256_BLOCK_SIZE seems not correct about crypto-algorithms HOT 4 CLOSED

from crypto-algorithms.

So you're implying that SHA256 yields a 64 byte hash? As far as I know, the hash is indeed 32 bytes. From the name "SHA256" it's visible that the hash is 256 bits long and that unsigned chars are used as bytes (8 bits), we can calculate that the hash is 256/8 (32) bytes long.

Maybe you're referring to the size of bytes if the hash is converted to a hexadecimal string and as one hexadecimal character represents 4 bits but takes 8 bits of space, the resulting "block" would be two times larger. This implementation does not store hashes as hexadecimal strings.

from crypto-algorithms.

@sijanec
Thanks for your reply. However, According to the SHA standard, the output value size and the block size might be different. For example, according to https://en.wikipedia.org/wiki/Secure_Hash_Algorithms, SHA-224 and SHA-256's output size is 28 and 32 respectively, but both of the block size are 64 bytes(512-bit).
Any comments?

/Sgetz

from crypto-algorithms.

@sijanec
Never mind. The library is very good and I appreciate your release. Moreover, It would not confuse anyone if you replace SHA256_BLOCK_SIZE with SHA256_OUTPUT_SIZE.
Just my 2 cents.:smile:
/Sgetz

from crypto-algorithms.