Giter Club home page Giter Club logo

Comments (5)

gsacavdm avatar gsacavdm commented on July 17, 2024 1

I've removed the first L#27 since this is no longer being used.
I'll investigate the second later.

Thanks for taking the time to provide feedback and help others!

from active-directory-b2c-wordpress-plugin-openidconnect.

gsacavdm avatar gsacavdm commented on July 17, 2024 1

Took care of second as well.

First handled with 06befa7
Second handled with 65195ce

from active-directory-b2c-wordpress-plugin-openidconnect.

TheSaltyKorean avatar TheSaltyKorean commented on July 17, 2024 1

Thanks! Super awesome job. I have it in my calendar to test and implement in 2 weeks.

from active-directory-b2c-wordpress-plugin-openidconnect.

gsacavdm avatar gsacavdm commented on July 17, 2024

I believe I've addressed this (my site was running at http://localhost/wp).
See

self::$redirect_uri = urlencode(site_url().'/');

Does this address your concerns?

from active-directory-b2c-wordpress-plugin-openidconnect.

TheSaltyKorean avatar TheSaltyKorean commented on July 17, 2024

Here's two lines I'm concerned with.

https://github.com/AzureAD/active-directory-b2c-wordpress-plugin-openidconnect/blob/master/b2c_authentication.php#L27

https://github.com/AzureAD/active-directory-b2c-wordpress-plugin-openidconnect/blob/master/b2c_authentication.php#L179

I'm in a tough spot, as I have it running on my site at the moment without the changes. I'll likely won't be able to test the updates for a week or two. Always Gerardo, excellent job and thank you for taking the project over!

from active-directory-b2c-wordpress-plugin-openidconnect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.